Skip to content

Implement empty PersonalAccessToken page in the dashboard #14614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #14280
laushinka opened this issue Nov 11, 2022 · 5 comments · Fixed by #14660
Closed
Tracked by #14280

Implement empty PersonalAccessToken page in the dashboard #14614

laushinka opened this issue Nov 11, 2022 · 5 comments · Fixed by #14660

Comments

@laushinka
Copy link
Contributor

laushinka commented Nov 11, 2022

Behind the feature flag personalAccessTokensEnabled

@laushinka laushinka changed the title Implement PersonalAccessToken page in the dashboard with empty token list Implement empty PersonalAccessToken page in the dashboard Nov 14, 2022
@laushinka laushinka moved this to In Progress in 🍎 WebApp Team Nov 14, 2022
Repository owner moved this from In Progress to In Validation in 🍎 WebApp Team Nov 14, 2022
@easyCZ easyCZ moved this from In Validation to Done in 🍎 WebApp Team Nov 21, 2022
@gtsiolis
Copy link
Contributor

The empty state contains more than the side menu, right? Shall we reopen this? Cc @laushinka @MichaelAring

See relevant comment in #14280 (comment)

1️⃣ No tokens
Empty

@laushinka
Copy link
Contributor Author

laushinka commented Nov 22, 2022

The empty state contains more than the side menu, right? Shall we reopen this? Cc @laushinka @MichaelAring

Thanks for the designs, George.
This ticket aimed to have an empty page behind a feature toggle, so that anyone who picks up the UI work can just start.
I don't think this is the same as what you show in the design, since it involves showing the list of personal access tokens and a modal to create new ones. So we don't have to reopen.

@gtsiolis
Copy link
Contributor

Thanks for clarifying, @laushinka!

I brought this up because this issue was listed in the tasks list in #14280. 💡

Let's leave this as is, hopefully the empty state can be tackled along with one of the tasks related to the UI like #14615. 🤝

@laushinka
Copy link
Contributor Author

Yess, now that we have designs we can polish the UI tickets. I think the listing and the creation can be worked on separate tickets, so I'll create the UI to only do the listing, as that is the one that's missing. Thanks for the nudge!

@laushinka
Copy link
Contributor Author

List tokens ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants