-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Highlight expired PATs in ListView #14947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Let's
|
Nice. How about we also add text so it says "Expired on Nov 24, 2022"? |
@laushinka I'd keep the verb out of there to avoid the duplication since we already have the column title. If we decide to redesign the table list layout or remove the list header we could duplicate this prefix to all tokens like the following:
However, it could make sense to duplicate the expiration prefix to make this information even more prominent. You're welcome to try using the prefix to see how this feels. |
That is a good point. Let's keep it as you proposed. |
When a PAT is expired, we s hould highlight it in some form to communicate the fact it is expired.
CC @gtsiolis if you've got design ideas how to do this.
The text was updated successfully, but these errors were encountered: