Skip to content

Highlight expired PATs in ListView #14947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #14280
easyCZ opened this issue Nov 25, 2022 · 4 comments · Fixed by #15015
Closed
Tracked by #14280

Highlight expired PATs in ListView #14947

easyCZ opened this issue Nov 25, 2022 · 4 comments · Fixed by #15015
Assignees
Labels
team: webapp Issue belongs to the WebApp team

Comments

@easyCZ
Copy link
Member

easyCZ commented Nov 25, 2022

When a PAT is expired, we s hould highlight it in some form to communicate the fact it is expired.

CC @gtsiolis if you've got design ideas how to do this.

@easyCZ easyCZ added the team: webapp Issue belongs to the WebApp team label Nov 25, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 25, 2022

Let's 🅰️ use an orange color for the expiration date to indicate that attention is required. Additionally, we could 🅱️ append an exclamation icon to make it more prominent, see designs below. Cc @easyCZ

🅰️ 🅱️
expires-a expires-b

@laushinka
Copy link
Contributor

Let's 🅰️ use an orange color for the expiration date to indicate that attention is required. Additionally, we could 🅱️ append an exclamation icon to make it more prominent, see designs below. Cc @easyCZ

Nice. How about we also add text so it says "Expired on Nov 24, 2022"?

@gtsiolis
Copy link
Contributor

@laushinka I'd keep the verb out of there to avoid the duplication since we already have the column title. If we decide to redesign the table list layout or remove the list header we could duplicate this prefix to all tokens like the following:

Token A
Expires on Dec 24, 2022

Token B
⚠️ Expired on Nov 24, 2022

However, it could make sense to duplicate the expiration prefix to make this information even more prominent. You're welcome to try using the prefix to see how this feels.

@laushinka
Copy link
Contributor

avoid the duplication since we already have the column title

That is a good point. Let's keep it as you proposed.

@easyCZ easyCZ moved this to Scheduled in 🍎 WebApp Team Nov 28, 2022
@mustard-mh mustard-mh mentioned this issue Nov 30, 2022
4 tasks
@mustard-mh mustard-mh self-assigned this Nov 30, 2022
@easyCZ easyCZ moved this from Scheduled to In Progress in 🍎 WebApp Team Nov 30, 2022
Repository owner moved this from In Progress to In Validation in 🍎 WebApp Team Dec 1, 2022
@easyCZ easyCZ moved this from In Validation to Done in 🍎 WebApp Team Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants