Skip to content

Updating a Token without any field modifications returns a Not Found #15105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #14280
easyCZ opened this issue Dec 1, 2022 · 1 comment · Fixed by #15108
Closed
Tracked by #14280

Updating a Token without any field modifications returns a Not Found #15105

easyCZ opened this issue Dec 1, 2022 · 1 comment · Fixed by #15108
Assignees
@easyCZ
Labels
feature: public-api Issues relating to Public API team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@easyCZ
Copy link
Member

easyCZ commented Dec 1, 2022 •
edited
Loading

Repro:

  1. Create a Token
  2. Edit the token
  3. Do not modify any input fields
  4. Press udpate
  5. Observe Not Found returned by API.
@easyCZ easyCZ mentioned this issue Dec 1, 2022
Closed
32 tasks
@easyCZ easyCZ added the team: webapp Issue belongs to the WebApp team label Dec 1, 2022
@easyCZ easyCZ moved this to Scheduled in 🍎 WebApp Team Dec 1, 2022
@easyCZ easyCZ added the type: bug Something isn't working label Dec 1, 2022
@easyCZ easyCZ mentioned this issue Dec 1, 2022
Merged
4 tasks
@easyCZ easyCZ moved this from Scheduled to In Progress in 🍎 WebApp Team Dec 1, 2022
@easyCZ easyCZ self-assigned this Dec 1, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Dec 1, 2022

The root cause of this issue that when the fields have not changed, MySQL returns 0 rows modified on that query

@easyCZ easyCZ mentioned this issue Dec 1, 2022
Merged
4 tasks
@easyCZ easyCZ moved this from In Progress to In Validation in 🍎 WebApp Team Dec 1, 2022
@easyCZ easyCZ moved this from In Validation to Done in 🍎 WebApp Team Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@easyCZ easyCZ

Labels
feature: public-api Issues relating to Public API team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
🍎 WebApp Team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pat] API allows update which does not change any data gitpod-io/gitpod
2 participants
@easyCZ @loujaybee