Skip to content

Unexpected result/error message on forked project from private repo in different org #7482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stockholmux opened this issue Jan 6, 2022 · 10 comments
Labels
git provider: github meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@stockholmux
Copy link

Bug description

I forked a private repo from an organization in Github. This organization has not granted GitPod permission for private repos. I have granted permission for GitPod to see private repos in my personal account.

When I try to get use gitpod on this private fork, I get the message Repository not found. / The repository 'stockholmux/<repo name>' is not found in your account. And it totally does! It took quite a while to understand what was going on.

I'm not sure if this is by-design and it makes some sense given the permission on the original organization, but the error message is really unhelpful.

Steps to reproduce

  1. Create a private repo in an organization that hasn't granted permissions for Gitpod
  2. Fork the private repo into your personal github account
  3. Grant access for gitpod to your personal account
  4. Attempt to access the forked repo via https://gitpod.io/#<repo url>
  5. See the error message.

Workspace affected

No response

Expected behavior

Either gitpod can access the the forked private repo or show an error message similar to the origin repo which makes sense: (e.g.Repository not found. / Permission to access private repositories has been granted. If you are a member of '<org name>', please try to request access for Gitpod.)

Example repository

No response

Anything else?

No response

@axonasif
Copy link
Member

axonasif commented Jan 7, 2022

I agree with you. I'm not sure but there can be some technical challenges here.

@stockholmux
Copy link
Author

@axonasif To my knowledge this is also not documented as a known issue. It would be nice to have something to preserve my hair - that shouldn't be a technical challenge.

@axonasif
Copy link
Member

axonasif commented Jan 7, 2022

that shouldn't be a technical challenge.

@stockholmux I meant that it could be a technical challenge to detect whether the private repo actually exists without having the necessary permissions granted beforehand. Sorry for not being clear enough 😅

@jldec jldec added the team: webapp Issue belongs to the WebApp team label Jan 10, 2022
@jldec
Copy link
Contributor

jldec commented Jan 10, 2022

Thank you for reporting this @stockholmux - we will investigate from the Gitpod side.

(I wonder if this may not be a bug on the GitHub api)

@jldec jldec moved this to Scheduled in 🍎 WebApp Team Jan 10, 2022
@jldec
Copy link
Contributor

jldec commented Jan 10, 2022

Scheduled.

A number of users have reported issues opening workspaces on private repos in the last week or so.
E.g https://discord.com/channels/816244985187008514/928500420966510702
cc: @axonasif

@jldec
Copy link
Contributor

jldec commented Jan 10, 2022

notes

  1. Allowing forking of private repos is a (fairly recent) feature that needs to be enabled in the GitHub org settings, before a fork is even possible.
    Screenshot 2022-01-10 at 21 55 44

  2. Granting third-party applications access to act on behalf of organization members (also in the org settings) is one way to get around the problem described above.
    Screenshot 2022-01-10 at 21 48 56

@stockholmux
Copy link
Author

@jldec Yeah, note 2 is unlikely in my organization (bummer, but not a blocker) but the error message was my big issue.

@jldec
Copy link
Contributor

jldec commented Feb 10, 2022

pushing for a fix for this also in #8076 since there are issues working directly with private repos on orgs.

@geropl geropl added type: bug Something isn't working git provider: github labels Apr 14, 2022
@geropl geropl removed the status in 🍎 WebApp Team Apr 14, 2022
@stale
Copy link

stale bot commented Jul 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 13, 2022
@stale stale bot closed this as completed Aug 13, 2022
@stale stale bot moved this to Done in 🍎 WebApp Team Aug 13, 2022
@geropl geropl added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Aug 22, 2022
@mittallakshayy
Copy link

Is there an update on this ? I was trying to use Gitpod with one of my forked repositories but the page says that the repository was not found on my account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git provider: github meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants