Skip to content

[jetbrains] extend IDE backend label #8192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akosyakov opened this issue Feb 14, 2022 · 2 comments · Fixed by #8371 or #9733
Closed

[jetbrains] extend IDE backend label #8192

akosyakov opened this issue Feb 14, 2022 · 2 comments · Fixed by #8371 or #9733

Comments

@akosyakov
Copy link
Member

Instead we should show there Gitpod logo and workspace id. In the dropdown menu we can add common actions, see #8024

We should override com.jetbrains.rdserver.unattendedHost.customization.GatewayClientCustomization for it. It is also possible to add actions to the dropdown menu by adding your actions to the UnattendedHostDropdownGroup action group.

@akosyakov akosyakov moved this to Scheduled in 🚀 IDE Team Feb 14, 2022
@akosyakov akosyakov self-assigned this Feb 21, 2022
@akosyakov akosyakov moved this from Scheduled to In Progress in 🚀 IDE Team Feb 21, 2022
@akosyakov akosyakov moved this from In Progress to In Review in 🚀 IDE Team Feb 22, 2022
@akosyakov akosyakov moved this from In Review to Awaiting Deployment in 🚀 IDE Team Feb 22, 2022
@akosyakov akosyakov moved this from Awaiting Deployment to Done in 🚀 IDE Team Feb 22, 2022
@akosyakov akosyakov reopened this Mar 2, 2022
@akosyakov akosyakov removed this from 🚀 IDE Team Mar 2, 2022
@akosyakov akosyakov removed their assignment Mar 2, 2022
@akosyakov
Copy link
Member Author

We had to revert it for now, since branding can cause JB backend freeze as for now: #8542 It will be improved in future versions and we can try again.

@felladrin
Copy link
Contributor

Recently, JetBrains team indicated us how to make it work, so I'll note it here for us to work on it later:

On plugin.xml add the following line inside <extensions defaultExtensionNs="com.intellij">:

<gateway.customization.name implementation="io.gitpod.jetbrains.remote.GitpodGatewayClientCustomizationProvider"/>

Then create a GitpodGatewayClientCustomizationProvider.kt file with the following content:

class GitpodGatewayClientCustomizationProvider : GatewayClientCustomizationProvider {
  override val icon: Icon = GitpodIcons.Logo
  override val title: String = "Gitpod"

  override val controlCenter: GatewayControlCenterProvider = object : GatewayControlCenterProvider {
    override fun getHostnameDisplayKind() = GatewayHostnameDisplayKind.ShowHostnameOnNavbar
    override fun getHostnameShort() = System.getenv("GITPOD_WORKSPACE_ID") ?: "Gitpod"
    override fun getHostnameLong() = getHostnameShort()
  }
}

Note: GitpodIcons is imported from here.

@felladrin felladrin moved this to Scheduled in 🚀 IDE Team May 2, 2022
@felladrin felladrin self-assigned this May 2, 2022
@felladrin felladrin moved this from Scheduled to Awaiting Deployment in 🚀 IDE Team May 11, 2022
@iQQBot iQQBot moved this from Awaiting Deployment to Done in 🚀 IDE Team May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants