Skip to content

Migrate AlertBox components to the new Alert component #9411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gtsiolis opened this issue Apr 19, 2022 · 1 comment · Fixed by #10199
Closed

Migrate AlertBox components to the new Alert component #9411

gtsiolis opened this issue Apr 19, 2022 · 1 comment · Fixed by #10199
Labels
aspect: tech-debt Issues related to engineering tech debt component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Back in #8783, we've added the next iteration of the alert component which introduces component variants for using the alert component for informing users, alerting users, etc.

Currently, there're two more Alert-like components which include InfoBox and AlertBox, see example screenshots below.

Component: InfoBox Component: Alert, Variant: Info
info-before info-after
Component: AlertBox Component: Alert, Variant: Warning
alert-before alert-after

Proposal

Migrate InfoBox (8 component instances) and AlertBox (5 component instances) components to the new Alert component. ➿
@gtsiolis gtsiolis added good-first-issue component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team aspect: tech-debt Issues related to engineering tech debt labels Apr 19, 2022
@gtsiolis gtsiolis mentioned this issue Apr 20, 2022
Closed
1 task
@gtsiolis gtsiolis mentioned this issue May 6, 2022
Open
@KevSlashNull KevSlashNull mentioned this issue May 23, 2022
Merged
1 task
@gtsiolis gtsiolis mentioned this issue May 24, 2022
Open
@gtsiolis gtsiolis changed the title Migrate InfoBox and AlertBox components to the new Alert component Migrate AlertBox components to the new Alert component May 24, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented May 24, 2022 •
edited
Loading

In the spirit of minimum viable change, I've updated the issue and split the InfoBox component migration to a separate issue in #10205. Thanks @KevSlashNull for picking this up!

@roboquat roboquat moved this to Done in 🍎 WebApp Team Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aspect: tech-debt Issues related to engineering tech debt component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience
Projects
🍎 WebApp Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace AlertBox with Alert component KevSlashNull/gitpod
2 participants
@gtsiolis @geropl