Skip to content

Commit 44cdf29

Browse files
Pothulapatimustard-mh
authored andcommitted
gitpod: bump node-fetch version in extensions
Related to gitpod-io/gitpod#7360 Currently, When the server has a root cert cross-signed by the expired `DST ROOT CA X3`. There's a possiblity of the client having an older version of `electron` in their code that causes the cert expiry failure. While, asking users to update their vs code should be our first suggestion, In some cases using the latest version of `node-fetch` also fixed the issue (not exactly sure why). This PR bumps the `node-fetch` dependency to the one that the `code-server` uses. Signed-off-by: Tarun Pothulapati <[email protected]>
1 parent 35e0a44 commit 44cdf29

File tree

3 files changed

+7
-14
lines changed

3 files changed

+7
-14
lines changed

extensions/gitpod-web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@
500500
},
501501
"dependencies": {
502502
"gitpod-shared": "0.0.1",
503-
"node-fetch": "^2.6.5",
503+
"node-fetch": "2.6.7",
504504
"uuid": "8.1.0",
505505
"vscode-jsonrpc": "^5.0.1",
506506
"vscode-nls": "^5.0.0",

extensions/gitpod/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"displayName": "%displayName%",
44
"description": "%description%",
55
"publisher": "gitpod",
6-
"version": "0.0.28",
6+
"version": "0.0.29",
77
"license": "MIT",
88
"preview": true,
99
"icon": "resources/gitpod.png",
@@ -45,7 +45,7 @@
4545
"dependencies": {
4646
"@gitpod/local-app-api-grpcweb": "main",
4747
"@improbable-eng/grpc-web-node-http-transport": "^0.14.0",
48-
"node-fetch": "^2.6.1",
48+
"node-fetch": "2.6.7",
4949
"tmp": "^0.2.1",
5050
"vscode-nls": "^5.0.0"
5151
},

extensions/yarn.lock

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -688,17 +688,10 @@ node-addon-api@^3.2.1:
688688
resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-3.2.1.tgz#81325e0a2117789c0128dab65e7e38f07ceba161"
689689
integrity sha512-mmcei9JghVNDYydghQmeDX8KoAm0FAiYyIcUt/N4nhyAipB17pllZQDOJD2fotxABnt4Mdz+dKTO7eftLg4d0A==
690690

691-
node-fetch@^2.6.1:
692-
version "2.6.6"
693-
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.6.tgz#1751a7c01834e8e1697758732e9efb6eeadfaf89"
694-
integrity sha512-Z8/6vRlTUChSdIgMa51jxQ4lrw/Jy5SOW10ObaA47/RElsAN2c5Pn8bTgFGWn/ibwzXTE8qwr1Yzx28vsecXEA==
695-
dependencies:
696-
whatwg-url "^5.0.0"
697-
698-
node-fetch@^2.6.5:
699-
version "2.6.5"
700-
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.5.tgz#42735537d7f080a7e5f78b6c549b7146be1742fd"
701-
integrity sha512-mmlIVHJEu5rnIxgEgez6b9GgWXbkZj5YZ7fx+2r94a2E+Uirsp6HsPTPlomfdHtpt/B0cdKviwkoaM6pyvUOpQ==
691+
692+
version "2.6.7"
693+
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.7.tgz#24de9fba827e3b4ae44dc8b20256a379160052ad"
694+
integrity sha512-ZjMPFEfVx5j+y2yF35Kzx5sF7kDzxuDj6ziH4FFbOp87zKDZNx8yExJIb05OGF4Nlt9IHFIMBkRl41VdvcNdbQ==
702695
dependencies:
703696
whatwg-url "^5.0.0"
704697

0 commit comments

Comments
 (0)