Skip to content

Commit 442c7f9

Browse files
committed
Fix setup.py and use of requirements files.
1 parent 7a6ca8c commit 442c7f9

File tree

4 files changed

+11
-14
lines changed

4 files changed

+11
-14
lines changed

git/cmd.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,8 @@ def refresh(cls, path=None):
220220
# - a GitCommandNotFound error is spawned by ourselves
221221
# - a PermissionError is spawned if the git executable provided
222222
# cannot be executed for whatever reason
223-
exceptions = (GitCommandNotFound, PermissionError)
223+
exceptions = (GitCommandNotFound, PermissionError) # noqa
224+
# (silence erroneous flake8 F821)
224225

225226
has_git = False
226227
try:

requirements.txt

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
gitdb>=0.6.4
2-
ddt>=1.1.1
1+
gitdb2 (>=2.0.0)

setup.py

+6-8
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
with open('requirements.txt') as reqs_file:
2020
requirements = reqs_file.read().splitlines()
2121

22+
with open('test-requirements.txt') as reqs_file:
23+
test_requirements = reqs_file.read().splitlines()
24+
2225

2326
class build_py(_build_py):
2427

@@ -63,10 +66,6 @@ def _stamp_version(filename):
6366
print("WARNING: Couldn't find version line in file %s" % filename, file=sys.stderr)
6467

6568

66-
install_requires = ['gitdb2 >= 2.0.0']
67-
test_requires = ['ddt>=1.1.1']
68-
# end
69-
7069
setup(
7170
name="GitPython",
7271
cmdclass={'build_py': build_py, 'sdist': sdist},
@@ -81,9 +80,8 @@ def _stamp_version(filename):
8180
package_dir={'git': 'git'},
8281
license="BSD License",
8382
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',
84-
requires=['gitdb2 (>=2.0.0)'],
85-
install_requires=install_requires,
86-
test_requirements=test_requires + install_requires,
83+
requires=requirements,
84+
tests_require=requirements + test_requirements,
8785
zip_safe=False,
8886
long_description="""GitPython is a python library used to interact with Git repositories""",
8987
classifiers=[
@@ -110,6 +108,6 @@ def _stamp_version(filename):
110108
"Programming Language :: Python :: 3.4",
111109
"Programming Language :: Python :: 3.5",
112110
"Programming Language :: Python :: 3.6",
113-
"Programming Language :: Python :: 3.7",
111+
"Programming Language :: Python :: 3.7"
114112
]
115113
)

test-requirements.txt

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
-r requirements.txt
2-
1+
ddt>=1.1.1
32
coverage
43
flake8
54
nose
6-
mock; python_version=='2.7'
5+
mock; python_version=='2.7'

0 commit comments

Comments
 (0)