Change warning refresh-mode tests to expect logging

This is instead of the current behavior writing the message to
stdout.

This commit does not change the behavior of the code under test,
but it changes tests to assert the following:

- "Bad git executable" messages are logged, at level CRITICAL.
- "log" (and "l") is recognized as another synonym of "warn".
- "silent" is recognized as a synonym of "quiet" (as "silence" is).

Although it is ambiguous whether this should be logged at level
ERROR or CRITICAL, because git.refresh is still expected to be
usable and can be called manually, not having a working git is a
condition in which GitPython, and any program that really relies on
its functionality, should be expected not work. That is the general
rationale for using CRIICAL here. There are also two specific
reasons:

- Existing messages GitPython logs as ERROR typically represent
  errors in individual operations on repositories, which could fail
  without indicating that GitPython's overall functionality is in
  an unusable state. Using the higher CRITICAL level for this
  situation makes sense for contrast.

- Prior to #1813, logging messsges emitted from GitPython modules,
  no matter the level, were suppressed when logging was not
  configured, but because this message was printed instead of
  being logged, it was still shown. Now that it is to be logged,
  there may be a benefit to have an easy way for someone to bring
  back a close approximation of the old behavior. Having this
  message be at a higher logging level makes that easier to do.
  (This is a less important reason, as that should rarely be done.)

test_initial_refresh_from_bad_git_path_env_warn is the main changed
test. All tests should pass again once code is changed for #1808.

Author: EliahKagan

Diff for: test/test_git.py

@@ -6,7 +6,6 @@
 import contextlib
 import gc
 import inspect
-import io
 import logging
 import os
 import os.path as osp
@@ -333,7 +332,7 @@ def test_cmd_override(self):
     def test_git_exc_name_is_git(self):
         self.assertEqual(self.git.git_exec_name, "git")
 
-    @ddt.data(("0",), ("q",), ("quiet",), ("s",), ("silence",), ("n",), ("none",))
+    @ddt.data(("0",), ("q",), ("quiet",), ("s",), ("silence",), ("silent",), ("n",), ("none",))
     def test_initial_refresh_from_bad_git_path_env_quiet(self, case):
         """In "q" mode, bad initial path sets "git" and is quiet."""
         (mode,) = case
@@ -348,9 +347,9 @@ def test_initial_refresh_from_bad_git_path_env_quiet(self, case):
                 refresh()
                 self.assertEqual(self.git.GIT_PYTHON_GIT_EXECUTABLE, "git")
 
-    @ddt.data(("1",), ("w",), ("warn",), ("warning",))
+    @ddt.data(("1",), ("w",), ("warn",), ("warning",), ("l",), ("log",))
     def test_initial_refresh_from_bad_git_path_env_warn(self, case):
-        """In "w" mode, bad initial path sets "git" and warns."""
+        """In "w" mode, bad initial path sets "git" and warns, by logging."""
         (mode,) = case
         env_vars = {
             "GIT_PYTHON_GIT_EXECUTABLE": str(Path("yada").absolute()),  # Any bad path.
@@ -360,9 +359,11 @@ def test_initial_refresh_from_bad_git_path_env_warn(self, case):
             type(self.git).GIT_PYTHON_GIT_EXECUTABLE = None  # Simulate startup.
 
             with mock.patch.dict(os.environ, env_vars):
-                with contextlib.redirect_stdout(io.StringIO()) as out:
+                with self.assertLogs(cmd.__name__, logging.CRITICAL) as ctx:
                     refresh()
-                self.assertRegex(out.getvalue(), r"\AWARNING: Bad git executable.\n")
+                self.assertEqual(len(ctx.records), 1)
+                message = ctx.records[0].getMessage()
+                self.assertRegex(message, r"\AWARNING: Bad git executable.\n")
                 self.assertEqual(self.git.GIT_PYTHON_GIT_EXECUTABLE, "git")
 
     @ddt.data(("2",), ("r",), ("raise",), ("e",), ("error",))