Skip to content

Staging lines doesn’t stage #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hadronized opened this issue Mar 2, 2023 · 7 comments
Open

Staging lines doesn’t stage #1580

hadronized opened this issue Mar 2, 2023 · 7 comments
Labels
bug Something isn't working question Further information is requested

Comments

@hadronized
Copy link

hadronized commented Mar 2, 2023

Describe the bug
Pressing s or any mapped key on diff_stage_lines doesn’t stage anything. However, it does unstage.

To Reproduce
Steps to reproduce the behavior:

  1. Just try to stage some lines.

Expected behavior
It should stage.

Screenshots
N/A

Context (please complete the following information):

 - OS/Distro + Version: Linux awake 6.1.12-arch1-1 #1 SMP PREEMPT_DYNAMIC Tue, 14 Feb 2023 22:08:08 +0000 x86_64 GNU/Linux
 - GitUI Version: `gitui 0.22.1`
 - Rust version: `rustc 1.66.1 (90743e729 2023-01-10)`

Additional context
N/A

@hadronized hadronized added the bug Something isn't working label Mar 2, 2023
@extrawurst
Copy link
Collaborator

can't reproduce:

Screenflick Movie 8

@extrawurst extrawurst added the question Further information is requested label Mar 4, 2023
@hadronized
Copy link
Author

Okay, I’ll try again and will provide more information.

@hadronized
Copy link
Author

I tried with a fresh build with master, and I still reproduce, whether I’m overriding the key or not.

@lightsnowball
Copy link
Contributor

@phaazon is this maybe the case for new files in your repo? I reproduced such behavior with a new file (more precisely, a file that is untracked).

@extrawurst is this expected for untracked files or should it be possible to stage such lines? I can make PR if needed.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label Mar 17, 2024
@willparsons
Copy link

Just tried gitui for the first time and this threw me off at first.

It does seem like this only happens if a file is untracked, so you would have to stage the entire file first then un-stage the lines you don't want. This only happens the first time but is definitely annoying.

@extrawurst Does this sound like a bug or is it intentional?

@stale stale bot removed the dormant Marked by stale bot on close label Nov 24, 2024
@hadronized
Copy link
Author

Yeah sorry I don’t really use gitui anymore (or actually any TUI anymore; most of them are too slow on super big monorepositories). However, I tried again and it seemed to work, so I guess something got fixed (I’m on a nightly).

And yeah, it doesn’t work on untracked files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants