Skip to content

Support core.hooksPath #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BuzzwordChief opened this issue Jul 7, 2021 · 5 comments
Closed

Support core.hooksPath #808

BuzzwordChief opened this issue Jul 7, 2021 · 5 comments
Labels
feature-request help wanted Extra attention is needed nostale immune to stale-bot
Milestone

Comments

@BuzzwordChief
Copy link

A global pre-commit hook (set with core.hooksPath) is ignored by gitui. It allows to commit the staged files even if the pre-commit hook returns with a non zero value.

To Reproduce
Create a pre-commit hook like this:

#! /bin/sh
exit 1

Expected behavior
the commit should fail, it doesn't.

@extrawurst
Copy link
Collaborator

@BuzzwordChief
Copy link
Author

Sorry, overlooked this somehow!

@extrawurst
Copy link
Collaborator

Sorry, overlooked this somehow!

no worries, we can keep it open in case someone is willing to pick it up. its a legit feature request

@extrawurst extrawurst reopened this Jul 7, 2021
@extrawurst extrawurst changed the title Pre-commit hook ignored Support Pre-commit hooks Jul 7, 2021
@extrawurst extrawurst changed the title Support Pre-commit hooks Support core.hooksPath Jul 11, 2021
@stale stale bot added the dormant Marked by stale bot on close label Oct 9, 2021
@extrawurst extrawurst added help wanted Extra attention is needed nostale immune to stale-bot and removed dormant Marked by stale bot on close labels Oct 11, 2021
@gitui-org gitui-org deleted a comment from stale bot Oct 11, 2021
@extrawurst
Copy link
Collaborator

implemented in #1044

@extrawurst extrawurst added this to the v0.20 milestone Jan 22, 2022
@extrawurst
Copy link
Collaborator

@BuzzwordChief if you feel like it please build master and try it out before this will be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request help wanted Extra attention is needed nostale immune to stale-bot
Projects
None yet
Development

No branches or pull requests

2 participants