Skip to content

Launch Editor from Compare Commits? #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
extrawurst opened this issue Oct 26, 2022 Discussed in #1407 · 1 comment · Fixed by #1430
Closed

Launch Editor from Compare Commits? #1409

extrawurst opened this issue Oct 26, 2022 Discussed in #1407 · 1 comment · Fixed by #1430
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@extrawurst
Copy link
Collaborator

Discussed in #1407

Originally posted by sez11a October 24, 2022
Stumbled upon GitUI, and I think it's great! It's missing one thing (as far as I can tell) that prevents me from using it. My use case is reviewing pull requests from others. To do that, I check out their branch, rebase master on top of it, and then launch GitUI.

In the Log view, I tag the top commit and the last commit from master, and then hit C to compare. GitUI shows a beautiful tree on the left with only the changed files in it and a diff on the right. If I could highlight one of those files and hit Enter or E to launch my default editor (neovim), GitUI would become my only Git client.

I'm not sure if I'm missing something in the config or if this is a feature request. Is this possible?

should be rather easy to implement. we even have such an edit-command in the file view/tab already.

@extrawurst extrawurst added the enhancement New feature or request label Oct 26, 2022
@extrawurst extrawurst added this to the v0.22 milestone Oct 26, 2022
@extrawurst extrawurst added the good first issue Good for newcomers label Oct 26, 2022
@sez11a
Copy link

sez11a commented Oct 26, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants