Commit 925be69
Avoid redundant calldata bytes extension (#173)
As @MartinquaXD
[noticed](#171 (comment)):
> This calldata needed to be changed (removed 24 bytes or 48 characters)
due to removing the extra encoding logic in the Permit2 handling. Turns
out that was not needed at all - not sure what made me believe that was
needed before.
To verify I used this
[page](https://calldata.swiss-knife.xyz/decoder?calldata=0x87517c45000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2000000000000000000000000136f1efcc3f8f88516b9e94110d56fdbfb1778d10000000000000000000000000000000000000000000000000de0b6b3a76400000000000000000000000000000000000000000000000000000000000000000000).
Pasting the shortened calldata still results in correct decoding but
removing 1 more character causes the decoding to fail.
This did not cause any issues so far because the EVM ignores additional
bytes instead of throwing an error.
This change has been extracted into a separate PR.
---------
Co-authored-by: Your Name <your-email@example.com>1 parent 05fe58e commit 925be69
2 files changed
Lines changed: 2 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | 54 | | |
60 | 55 | | |
61 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | | - | |
| 337 | + | |
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
| |||
0 commit comments