Skip to content

Commit a18b4c4

Browse files
committed
action_sheet [nfc]: Update TODO comment about keyboard vs. iOS share sheet
We closed issue zulip#24 because it was apparently resolved by an OS update. There's still a milder issue; mention that instead.
1 parent e898fd3 commit a18b4c4

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

lib/widgets/action_sheet.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -484,10 +484,9 @@ class ShareButton extends MessageActionSheetMenuItemButton {
484484
// sheet. (We could do this after the sharing Future settles
485485
// with [ShareResultStatus.success], but on iOS I get impatient with
486486
// how slowly our action sheet dismisses in that case.)
487-
// TODO(#24): Fix iOS bug where this call causes the keyboard to
488-
// reopen (if it was open at the time of this
489-
// `showMessageActionSheet` call) and cover a large part of the
490-
// share sheet.
487+
// TODO(#591): Fix iOS bug where if the keyboard was open before the call
488+
// to `showMessageActionSheet`, it reappears briefly between
489+
// the `pop` of the action sheet and the appearance of the share sheet.
491490
Navigator.of(context).pop();
492491
final zulipLocalizations = ZulipLocalizations.of(pageContext);
493492

0 commit comments

Comments
 (0)