Skip to content

Commit a766e39

Browse files
committed
wip api [nfc]: Cut allow_nobody_group comments on permission settings; TODO this might be clearer after we do use the newly-declared-stable API on new servers
Rereading the API doc, this field is relevant only for controlling a settings UI. We probably will build settings UI for at least some of these settings in the future; but naturally we'll only expose that UI for servers that offer the respective settings, which means we can rely on getting the data from the actual server rather than using a fixture based on a particular other server version. (And we can also expect to have already by then started when we do, it'll be driven by the actual values gotten from the server, so won't be needed in this fixture
1 parent b16ab7f commit a766e39

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

lib/api/model/initial_snapshot.dart

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -431,52 +431,42 @@ class SupportedPermissionSettings {
431431
// From the server's Stream.stream_permission_group_settings,
432432
// in zerver/models/streams.py. Current as of f9dc13014, 2025-08.
433433
"can_add_subscribers_group": PermissionSettingsItem(
434-
// allow_nobody_group=True,
435434
allowEveryoneGroup: false,
436435
// default_group_name=SystemGroups.NOBODY,
437436
),
438437
"can_administer_channel_group": PermissionSettingsItem(
439-
// allow_nobody_group=True,
440438
allowEveryoneGroup: false,
441439
// default_group_name="stream_creator_or_nobody",
442440
),
443441
"can_delete_any_message_group": PermissionSettingsItem(
444-
// allow_nobody_group=True,
445442
allowEveryoneGroup: true,
446443
// default_group_name=SystemGroups.NOBODY,
447444
),
448445
"can_delete_own_message_group": PermissionSettingsItem(
449-
// allow_nobody_group=True,
450446
allowEveryoneGroup: true,
451447
// default_group_name=SystemGroups.NOBODY,
452448
),
453449
"can_move_messages_out_of_channel_group": PermissionSettingsItem(
454-
// allow_nobody_group=True,
455450
allowEveryoneGroup: true,
456451
// default_group_name=SystemGroups.NOBODY,
457452
),
458453
"can_move_messages_within_channel_group": PermissionSettingsItem(
459-
// allow_nobody_group=True,
460454
allowEveryoneGroup: true,
461455
// default_group_name=SystemGroups.NOBODY,
462456
),
463457
"can_remove_subscribers_group": PermissionSettingsItem(
464-
// allow_nobody_group=True,
465458
allowEveryoneGroup: true,
466459
// default_group_name=SystemGroups.ADMINISTRATORS,
467460
),
468461
"can_send_message_group": PermissionSettingsItem(
469-
// allow_nobody_group=True,
470462
allowEveryoneGroup: true,
471463
// default_group_name=SystemGroups.EVERYONE,
472464
),
473465
"can_subscribe_group": PermissionSettingsItem(
474-
// allow_nobody_group=True,
475466
allowEveryoneGroup: false,
476467
// default_group_name=SystemGroups.NOBODY,
477468
),
478469
"can_resolve_topics_group": PermissionSettingsItem(
479-
// allow_nobody_group=True,
480470
allowEveryoneGroup: true,
481471
// default_group_name=SystemGroups.NOBODY,
482472
),

0 commit comments

Comments
 (0)