don't convert buffer to string (#7115)

lunny · web-flow · commit 111d31d6810c · 2019-08-22T12:52:40.000+08:00
diff --git a/models/issue_comment.go b/models/issue_comment.go
@@ -910,7 +910,7 @@ func CreateCodeComment(doer *User, repo *Repository, issue *Issue, content, tree
 		if err := GetRawDiffForFile(gitRepo.Path, pr.MergeBase, headCommitID, RawDiffNormal, treePath, patchBuf); err != nil {
 			return nil, fmt.Errorf("GetRawDiffForLine[%s, %s, %s, %s]: %v", err, gitRepo.Path, pr.MergeBase, headCommitID, treePath)
 		}
-		patch = CutDiffAroundLine(strings.NewReader(patchBuf.String()), int64((&Comment{Line: line}).UnsignedLine()), line < 0, setting.UI.CodeCommentLines)
+		patch = CutDiffAroundLine(patchBuf, int64((&Comment{Line: line}).UnsignedLine()), line < 0, setting.UI.CodeCommentLines)
 	}
 	return CreateComment(&CreateCommentOptions{
 		Type:      CommentTypeCode,

Original file line number	Diff line number	Diff line change
`@@ -910,7 +910,7 @@ func CreateCodeComment(doer User, repo Repository, issue *Issue, content, tree`
`910`	`910`	`if err := GetRawDiffForFile(gitRepo.Path, pr.MergeBase, headCommitID, RawDiffNormal, treePath, patchBuf); err != nil {`
`911`	`911`	`return nil, fmt.Errorf("GetRawDiffForLine[%s, %s, %s, %s]: %v", err, gitRepo.Path, pr.MergeBase, headCommitID, treePath)`
`912`	`912`	`}`
`913`		`- patch = CutDiffAroundLine(strings.NewReader(patchBuf.String()), int64((&Comment{Line: line}).UnsignedLine()), line < 0, setting.UI.CodeCommentLines)`
	`913`	`+ patch = CutDiffAroundLine(patchBuf, int64((&Comment{Line: line}).UnsignedLine()), line < 0, setting.UI.CodeCommentLines)`
`914`	`914`	`}`
`915`	`915`	`return CreateComment(&CreateCommentOptions{`
`916`	`916`	`Type: CommentTypeCode,`