Skip to content

Commit 29ac316

Browse files
authored
Release page show all tags in compare dropdown (#20070) (#20072)
Backport #20070 Just get all tags when creating the compare dropdown. Fix #19936
1 parent 710a141 commit 29ac316

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

routers/web/repo/release.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,14 @@ func releasesOrTags(ctx *context.Context, isTagList bool) {
9898
listOptions.PageSize = setting.API.MaxResponseItems
9999
}
100100

101-
tags, err := ctx.Repo.GitRepo.GetTags(listOptions.GetStartEnd())
101+
// TODO(20073) tags are used for compare feature witch needs all tags
102+
// filtering is doen at the client side atm
103+
tagListStart, tagListEnd := 0, 0
104+
if isTagList {
105+
tagListStart, tagListEnd = listOptions.GetStartEnd()
106+
}
107+
108+
tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd)
102109
if err != nil {
103110
ctx.ServerError("GetTags", err)
104111
return

0 commit comments

Comments
 (0)