Skip to content

Commit 306767b

Browse files
silverwindsilverwind
committed
rename to code-expander-button, fix styles
1 parent 29733fd commit 306767b

File tree

6 files changed

+17
-16
lines changed

6 files changed

+17
-16
lines changed

‎templates/repo/diff/blob_excerpt.tmpl

+6-6
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@
55
<td class="lines-num lines-num-old" data-line-num="{{if $line.LeftIdx}}{{$line.LeftIdx}}{{end}}">
66
<div class="gt-df">
77
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 5)}}
8-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=down&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
8+
<button class="code-expander-button gt-f1" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=down&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
99
{{svg "octicon-fold-down"}}
1010
</button>
1111
{{end}}
1212
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 4)}}
13-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=up&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
13+
<button class="code-expander-button gt-f1" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=up&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
1414
{{svg "octicon-fold-up"}}
1515
</button>
1616
{{end}}
1717
{{if eq $line.GetExpandDirection 2}}
18-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
18+
<button class="code-expander-button gt-f1" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
1919
{{svg "octicon-fold"}}
2020
</button>
2121
{{end}}
@@ -50,17 +50,17 @@
5050
{{if eq .GetType 4}}
5151
<td colspan="2" class="lines-num">
5252
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 5)}}
53-
<button class="blob-excerpt button button-ghost" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=down&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
53+
<button class="code-expander-button" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=down&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
5454
{{svg "octicon-fold-down"}}
5555
</button>
5656
{{end}}
5757
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 4)}}
58-
<button class="blob-excerpt button button-ghost" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=up&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
58+
<button class="code-expander-button" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=up&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
5959
{{svg "octicon-fold-up"}}
6060
</button>
6161
{{end}}
6262
{{if eq $line.GetExpandDirection 2}}
63-
<button class="blob-excerpt button button-ghost" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
63+
<button class="code-expander-button" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=&wiki={{$.PageIsWiki}}" data-anchor="{{$.Anchor}}">
6464
{{svg "octicon-fold"}}
6565
</button>
6666
{{end}}

‎templates/repo/diff/section_split.tmpl

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,17 @@
1818
<td class="lines-num lines-num-old">
1919
<div class="gt-df">
2020
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 5)}}
21-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=down&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
21+
<button class="code-expander-button gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=down&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
2222
{{svg "octicon-fold-down"}}
2323
</button>
2424
{{end}}
2525
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 4)}}
26-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=up&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
26+
<button class="code-expander-button gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=up&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
2727
{{svg "octicon-fold-up"}}
2828
</button>
2929
{{end}}
3030
{{if eq $line.GetExpandDirection 2}}
31-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
31+
<button class="code-expander-button gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
3232
{{svg "octicon-fold"}}
3333
</button>
3434
{{end}}

‎templates/repo/diff/section_unified.tmpl

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,17 @@
1414
<td colspan="2" class="lines-num">
1515
<div class="gt-df">
1616
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 5)}}
17-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=down&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
17+
<button class="code-expander-button gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=down&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
1818
{{svg "octicon-fold-down"}}
1919
</button>
2020
{{end}}
2121
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 4)}}
22-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=up&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
22+
<button class="code-expander-button gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=up&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
2323
{{svg "octicon-fold-up"}}
2424
</button>
2525
{{end}}
2626
{{if eq $line.GetExpandDirection 2}}
27-
<button class="blob-excerpt button button-ghost gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
27+
<button class="code-expander-button gt-f1" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=&wiki={{$.root.PageIsWiki}}" data-anchor="diff-{{$file.NameHash}}K{{$line.SectionInfo.RightIdx}}">
2828
{{svg "octicon-fold"}}
2929
</button>
3030
{{end}}

‎web_src/css/repo.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -2943,7 +2943,7 @@ tbody.commit-list {
29432943
padding-top: 0 !important;
29442944
}
29452945

2946-
td.blob-excerpt {
2946+
.blob-excerpt {
29472947
background-color: var(--color-secondary-alpha-30);
29482948
}
29492949

‎web_src/css/review.css

+3-2
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,8 @@
198198
color: var(--color-text);
199199
}
200200

201-
.blob-excerpt {
201+
.code-expander-button {
202+
border: none;
202203
color: var(--color-text-light);
203204
height: 28px;
204205
display: flex;
@@ -208,7 +209,7 @@
208209
background: var(--color-expand-button);
209210
}
210211

211-
.blob-excerpt:hover {
212+
.code-expander-button:hover {
212213
background: var(--color-primary);
213214
color: var(--color-primary-contrast);
214215
}

‎web_src/js/features/repo-code.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ export function initRepoCodeView() {
181181
$(document).on('click', '.fold-file', ({currentTarget}) => {
182182
invertFileFolding(currentTarget.closest('.file-content'), currentTarget);
183183
});
184-
$(document).on('click', '.blob-excerpt', async ({currentTarget}) => {
184+
$(document).on('click', '.code-expander-button', async ({currentTarget}) => {
185185
const url = currentTarget.getAttribute('data-url');
186186
const query = currentTarget.getAttribute('data-query');
187187
const anchor = currentTarget.getAttribute('data-anchor');

0 commit comments

Comments
 (0)