fine tune

Author: wxiaoguang

modules/templates/util_avatar.go

@@ -34,6 +34,7 @@ func AvatarHTML(src string, size int, class, name string) template.HTML {
 		name = "avatar"
 	}
 
+	// use empty alt, otherwise if the image fails to load, the width will follow the "alt" text's width
 	return template.HTML(`<img loading="lazy" alt="" class="` + class + `" src="` + src + `" title="` + html.EscapeString(name) + `" width="` + sizeStr + `" height="` + sizeStr + `"/>`)
 }
 

web_src/js/modules/fomantic/dropdown.test.ts

@@ -15,9 +15,9 @@ test('hideScopedEmptyDividers-simple', () => {
   expect(container.innerHTML).toEqual(`
 <div class="divider hidden transition"></div>
 <div class="item">a</div>
-<div class="divider"></div>
 <div class="divider hidden transition"></div>
 <div class="divider hidden transition"></div>
+<div class="divider"></div>
 <div class="item">b</div>
 <div class="divider hidden transition"></div>
 `);
@@ -35,10 +35,10 @@ test('hideScopedEmptyDividers-items-all-filtered', () => {
   hideScopedEmptyDividers(container);
   expect(container.innerHTML).toEqual(`
 <div class="any"></div>
-<div class="divider"></div>
+<div class="divider hidden transition"></div>
 <div class="item filtered">a</div>
 <div class="item filtered">b</div>
-<div class="divider hidden transition"></div>
+<div class="divider"></div>
 <div class="any"></div>
 `);
 });

web_src/js/modules/fomantic/dropdown.ts

@@ -341,7 +341,7 @@ export function hideScopedEmptyDividers(container: Element) {
   // no need to update "visibleItems" array since this is the last loop
   for (let i = 0; i < visibleItems.length - 1; i++) {
     if (!visibleItems[i].matches('.divider')) continue;
-    if (visibleItems[i + 1].matches('.divider')) hideDivider(visibleItems[i + 1]);
+    if (visibleItems[i + 1].matches('.divider')) hideDivider(visibleItems[i]);
   }
 }