fine tune types

Author: wxiaoguang

web_src/js/markup/render-iframe.test.ts

@@ -8,9 +8,9 @@ test('safeLinkHref', () => {
   expect(safeLinkHref('javascript:void(0);')).toBeNull();
   expect(safeLinkHref('data:image/svg+xml;utf8,<svg></svg>')).toBeNull();
   // for safety and consistency, it converts non-string input to string (just like window.location.href = 0)
-  expect(safeLinkHref(0 as any)).toBe('http://localhost:3000/0');
-  expect(safeLinkHref({} as any)).toBe('http://localhost:3000/[object%20Object]');
-  expect(safeLinkHref(null as any)).toBe('http://localhost:3000/null');
+  expect(safeLinkHref(0)).toBe('http://localhost:3000/0');
+  expect(safeLinkHref({})).toBe('http://localhost:3000/[object%20Object]');
+  expect(safeLinkHref(null)).toBe('http://localhost:3000/null');
 });
 
 test('navigateToIframeLink', () => {
@@ -33,6 +33,10 @@ test('navigateToIframeLink', () => {
   expect(assignSpy).toHaveBeenCalledWith('http://localhost:3000/path');
   vi.clearAllMocks();
 
+  navigateToIframeLink(123, {}); // input can be any type & any value
+  expect(assignSpy).toHaveBeenCalledWith('http://localhost:3000/null');
+  vi.clearAllMocks();
+
   // eslint-disable-next-line no-script-url
   navigateToIframeLink('javascript:void(0);', '_blank');
   expect(openSpy).toHaveBeenCalledTimes(0);

web_src/js/markup/render-iframe.ts

@@ -1,7 +1,8 @@
 import {generateElemId, queryElemChildren} from '../utils/dom.ts';
 import {isDarkTheme} from '../utils.ts';
 
-export function safeLinkHref(link: string): string | null {
+// arguments can be any type & any value, they are from "message" event's data
+export function safeLinkHref(link: any): string | null {
   try {
     const url = new URL(`${link}`, window.location.href);
     if (url.protocol !== 'http:' && url.protocol !== 'https:') {
@@ -15,7 +16,8 @@ export function safeLinkHref(link: string): string | null {
   }
 }
 
-export function navigateToIframeLink(unsafeLink: string, target: string | null) {
+// arguments can be any type & any value, they are from "message" event's data
+export function navigateToIframeLink(unsafeLink: any, target: any) {
   const linkHref = safeLinkHref(unsafeLink);
   if (linkHref === null) return;
   if (target === '_blank') {