Skip to content

Commit 495eb4a

Browse files
lunnylunny
committed
Fix test
1 parent 9803449 commit 495eb4a

File tree

3 files changed

+135
-130
lines changed

3 files changed

+135
-130
lines changed

‎Makefile

Lines changed: 1 addition & 127 deletions
Original file line numberDiff line numberDiff line change
@@ -473,133 +473,7 @@ unit-test-coverage:
473473

474474
.PHONY: test-coverage-check
475475
test-coverage-check:
476-
@$(GO) run build/gocoverage.go check coverage.all \
477-
code.gitea.io/gitea/modules/activitypub=60.66% \
478-
code.gitea.io/gitea/modules/analyze=73.91% \
479-
code.gitea.io/gitea/modules/auth=60.29% \
480-
code.gitea.io/gitea/modules/avatar=55.20% \
481-
code.gitea.io/gitea/modules/base=92.96% \
482-
code.gitea.io/gitea/modules/cache=14.5% \
483-
code.gitea.io/gitea/modules/charset=56.67% \
484-
code.gitea.io/gitea/modules/container=100.00% \
485-
code.gitea.io/gitea/modules/context=58.91% \
486-
code.gitea.io/gitea/modules/csv=100.00% \
487-
code.gitea.io/gitea/modules/doctor=15.1% \
488-
code.gitea.io/gitea/modules/emoji=83.3% \
489-
code.gitea.io/gitea/modules/eventsource=53.88% \
490-
code.gitea.io/gitea/modules/generate=0.00% \
491-
code.gitea.io/gitea/modules/git=61.93% \
492-
code.gitea.io/gitea/modules/gitgraph=75.77% \
493-
code.gitea.io/gitea/modules/graceful=29.0% \
494-
code.gitea.io/gitea/modules/hcaptcha=0.00% \
495-
code.gitea.io/gitea/modules/highlight=67.14% \
496-
code.gitea.io/gitea/modules/hostmatcher=79.34% \
497-
code.gitea.io/gitea/modules/html=100.00% \
498-
code.gitea.io/gitea/modules/httpcache=78.95% \
499-
code.gitea.io/gitea/modules/httplib=67.86% \
500-
code.gitea.io/gitea/modules/indexer=39.21% \
501-
code.gitea.io/gitea/modules/issue=75.47% \
502-
code.gitea.io/gitea/modules/json=43.75% \
503-
code.gitea.io/gitea/modules/lfs=70.98% \
504-
code.gitea.io/gitea/modules/log=69.41% \
505-
code.gitea.io/gitea/modules/markup=53.32% \
506-
code.gitea.io/gitea/modules/mcaptcha=0.00% \
507-
code.gitea.io/gitea/modules/metrics=0.00% \
508-
code.gitea.io/gitea/modules/migration=70.45% \
509-
code.gitea.io/gitea/modules/mirror=16.67% \
510-
code.gitea.io/gitea/modules/nosql=29.21% \
511-
code.gitea.io/gitea/modules/notification=64.94% \
512-
code.gitea.io/gitea/modules/options=48.74% \
513-
code.gitea.io/gitea/modules/packages=70.63% \
514-
code.gitea.io/gitea/modules/paginator=100.00% \
515-
code.gitea.io/gitea/modules/password=66.18% \
516-
code.gitea.io/gitea/modules/pprof=0.00% \
517-
code.gitea.io/gitea/modules/private=13.40% \
518-
code.gitea.io/gitea/modules/process=38.5% \
519-
code.gitea.io/gitea/modules/proxy=17.2% \
520-
code.gitea.io/gitea/modules/proxyprotocol=0.00% \
521-
code.gitea.io/gitea/modules/public=53.26% \
522-
code.gitea.io/gitea/modules/queue=39.17% \
523-
code.gitea.io/gitea/modules/recaptcha=0.00% \
524-
code.gitea.io/gitea/modules/references=80.50% \
525-
code.gitea.io/gitea/modules/regexplru=65.22% \
526-
code.gitea.io/gitea/modules/repository=49.68% \
527-
code.gitea.io/gitea/modules/secret=64.00% \
528-
code.gitea.io/gitea/modules/session=18.63% \
529-
code.gitea.io/gitea/modules/setting=54.19% \
530-
code.gitea.io/gitea/modules/sitemap=82.35% \
531-
code.gitea.io/gitea/modules/ssh=45.98% \
532-
code.gitea.io/gitea/modules/storage=57.14% \
533-
code.gitea.io/gitea/modules/structs=54.22% \
534-
code.gitea.io/gitea/modules/svg=94.4% \
535-
code.gitea.io/gitea/modules/sync=100.00% \
536-
code.gitea.io/gitea/modules/system=70.00% \
537-
code.gitea.io/gitea/modules/templates=43.01% \
538-
code.gitea.io/gitea/modules/test=68.83% \
539-
code.gitea.io/gitea/modules/timeutil=80.80% \
540-
code.gitea.io/gitea/modules/translation=60.70% \
541-
code.gitea.io/gitea/modules/typesniffer=92.86% \
542-
code.gitea.io/gitea/modules/updatechecker=0.00% \
543-
code.gitea.io/gitea/modules/upload=73.85% \
544-
code.gitea.io/gitea/modules/uri=27.78% \
545-
code.gitea.io/gitea/modules/user=23.53% \
546-
code.gitea.io/gitea/modules/util=72.93% \
547-
code.gitea.io/gitea/modules/validation=79.4% \
548-
code.gitea.io/gitea/modules/watcher=0.00% \
549-
code.gitea.io/gitea/modules/web=76.76% \
550-
code.gitea.io/gitea/modules/webhook=13.3% \
551-
code.gitea.io/gitea/models/activities=58.48% \
552-
code.gitea.io/gitea/models/admin=33.55% \
553-
code.gitea.io/gitea/models/asymkey=41.40% \
554-
code.gitea.io/gitea/models/auth=46.36% \
555-
code.gitea.io/gitea/models/avatars=31.82% \
556-
code.gitea.io/gitea/models/db=41.53% \
557-
code.gitea.io/gitea/models/git=44.19% \
558-
code.gitea.io/gitea/models/issues=57.31% \
559-
code.gitea.io/gitea/models/organization=71.00% \
560-
code.gitea.io/gitea/models/packages=71.66% \
561-
code.gitea.io/gitea/models/perm=57.05% \
562-
code.gitea.io/gitea/models/project=31.85% \
563-
code.gitea.io/gitea/models/pull=36.13% \
564-
code.gitea.io/gitea/models/repo=58.62% \
565-
code.gitea.io/gitea/models/secret=24.56% \
566-
code.gitea.io/gitea/models/system=56.16% \
567-
code.gitea.io/gitea/models/unit=48.72% \
568-
code.gitea.io/gitea/models/unittest=31.91% \
569-
code.gitea.io/gitea/models/user=55.82% \
570-
code.gitea.io/gitea/models/webhook=66.02% \
571-
code.gitea.io/gitea/routers/api=60.66% \
572-
code.gitea.io/gitea/routers/common=61.15% \
573-
code.gitea.io/gitea/routers/install=5.7% \
574-
code.gitea.io/gitea/routers/private=34.74% \
575-
code.gitea.io/gitea/routers/utils=100.00% \
576-
code.gitea.io/gitea/routers/web=28.95% \
577-
code.gitea.io/gitea/services/agit=56.59% \
578-
code.gitea.io/gitea/services/asymkey=36.73% \
579-
code.gitea.io/gitea/services/attachment=60.87% \
580-
code.gitea.io/gitea/services/auth=38.99% \
581-
code.gitea.io/gitea/services/automerge=44.83% \
582-
code.gitea.io/gitea/services/context=47.22% \
583-
code.gitea.io/gitea/services/convert=73.5% \
584-
code.gitea.io/gitea/services/cron=56.2% \
585-
code.gitea.io/gitea/services/externalaccount=0.00% \
586-
code.gitea.io/gitea/services/forms=36.5% \
587-
code.gitea.io/gitea/services/gitdiff=70.52% \
588-
code.gitea.io/gitea/services/issue=40.50% \
589-
code.gitea.io/gitea/services/lfs=57.06% \
590-
code.gitea.io/gitea/services/mailer=54.55% \
591-
code.gitea.io/gitea/services/markup=100.00% \
592-
code.gitea.io/gitea/services/migrations=35.97% \
593-
code.gitea.io/gitea/services/mirror=29.83% \
594-
code.gitea.io/gitea/services/org=49.02% \
595-
code.gitea.io/gitea/services/packages=51.94% \
596-
code.gitea.io/gitea/services/pull=43.34% \
597-
code.gitea.io/gitea/services/release=45.09% \
598-
code.gitea.io/gitea/services/repository=41.19% \
599-
code.gitea.io/gitea/services/task=43.75% \
600-
code.gitea.io/gitea/services/user=46.24% \
601-
code.gitea.io/gitea/services/webhook=66.63% \
602-
code.gitea.io/gitea/services/wiki=56.41% \
476+
@$(GO) run build/gocoverage.go check coverage.all tests/coverage_requirement.txt
603477

604478
.PHONY: tidy
605479
tidy:

‎build/gocoverage.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,17 +183,22 @@ func profileCount(p *cover.Profile) (int64, int64) {
183183
}
184184

185185
func checkPackages(args []string) {
186-
if len(args) < 2 {
186+
if len(args) != 2 {
187187
log.Fatalf("invalid arguments: %v", args)
188188
return
189189
}
190-
coverageFile, packages := args[0], args[1:]
190+
coverageFile, packagesFile := args[0], args[1]
191191
profiles, err := cover.ParseProfiles(coverageFile)
192192
if err != nil {
193193
log.Fatalf("failed to parse profile '%s': %v", coverageFile, err)
194194
}
195195
packagesRequirements := make(map[string]int64)
196-
for _, p := range packages {
196+
packages, err := os.ReadFile(packagesFile)
197+
if err != nil {
198+
log.Fatalf("failed to read packages file '%s': %v", packagesFile, err)
199+
}
200+
lines := strings.Split(string(packages), "\n")
201+
for _, p := range lines {
197202
parts := strings.Split(p, "=")
198203
if len(parts) != 2 {
199204
continue

‎tests/coverage_requirement.txt

Lines changed: 126 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,126 @@
1+
code.gitea.io/gitea/modules/activitypub=60.66%
2+
code.gitea.io/gitea/modules/analyze=73.91%
3+
code.gitea.io/gitea/modules/auth=60.29%
4+
code.gitea.io/gitea/modules/avatar=55.20%
5+
code.gitea.io/gitea/modules/base=92.96%
6+
code.gitea.io/gitea/modules/cache=14.5%
7+
code.gitea.io/gitea/modules/charset=56.67%
8+
code.gitea.io/gitea/modules/container=100.00%
9+
code.gitea.io/gitea/modules/context=58.91%
10+
code.gitea.io/gitea/modules/csv=100.00%
11+
code.gitea.io/gitea/modules/doctor=15.1%
12+
code.gitea.io/gitea/modules/emoji=83.3%
13+
code.gitea.io/gitea/modules/eventsource=53.88%
14+
code.gitea.io/gitea/modules/generate=0.00%
15+
code.gitea.io/gitea/modules/git=61.93%
16+
code.gitea.io/gitea/modules/gitgraph=75.77%
17+
code.gitea.io/gitea/modules/graceful=29.0%
18+
code.gitea.io/gitea/modules/hcaptcha=0.00%
19+
code.gitea.io/gitea/modules/highlight=67.14%
20+
code.gitea.io/gitea/modules/hostmatcher=79.34%
21+
code.gitea.io/gitea/modules/html=100.00%
22+
code.gitea.io/gitea/modules/httpcache=78.95%
23+
code.gitea.io/gitea/modules/httplib=67.86%
24+
code.gitea.io/gitea/modules/indexer=39.21%
25+
code.gitea.io/gitea/modules/issue=75.47%
26+
code.gitea.io/gitea/modules/json=43.75%
27+
code.gitea.io/gitea/modules/lfs=70.98%
28+
code.gitea.io/gitea/modules/log=69.41%
29+
code.gitea.io/gitea/modules/markup=53.32%
30+
code.gitea.io/gitea/modules/mcaptcha=0.00%
31+
code.gitea.io/gitea/modules/metrics=0.00%
32+
code.gitea.io/gitea/modules/migration=70.45%
33+
code.gitea.io/gitea/modules/mirror=16.67%
34+
code.gitea.io/gitea/modules/nosql=29.21%
35+
code.gitea.io/gitea/modules/notification=64.94%
36+
code.gitea.io/gitea/modules/options=48.74%
37+
code.gitea.io/gitea/modules/packages=70.63%
38+
code.gitea.io/gitea/modules/paginator=100.00%
39+
code.gitea.io/gitea/modules/password=66.18%
40+
code.gitea.io/gitea/modules/pprof=0.00%
41+
code.gitea.io/gitea/modules/private=13.40%
42+
code.gitea.io/gitea/modules/process=38.5%
43+
code.gitea.io/gitea/modules/proxy=17.2%
44+
code.gitea.io/gitea/modules/proxyprotocol=0.00%
45+
code.gitea.io/gitea/modules/public=53.26%
46+
code.gitea.io/gitea/modules/queue=39.17%
47+
code.gitea.io/gitea/modules/recaptcha=0.00%
48+
code.gitea.io/gitea/modules/references=80.50%
49+
code.gitea.io/gitea/modules/regexplru=65.22%
50+
code.gitea.io/gitea/modules/repository=49.68%
51+
code.gitea.io/gitea/modules/secret=64.00%
52+
code.gitea.io/gitea/modules/session=18.63%
53+
code.gitea.io/gitea/modules/setting=54.19%
54+
code.gitea.io/gitea/modules/sitemap=82.35%
55+
code.gitea.io/gitea/modules/ssh=45.98%
56+
code.gitea.io/gitea/modules/storage=57.14%
57+
code.gitea.io/gitea/modules/structs=54.22%
58+
code.gitea.io/gitea/modules/svg=94.4%
59+
code.gitea.io/gitea/modules/sync=100.00%
60+
code.gitea.io/gitea/modules/system=70.00%
61+
code.gitea.io/gitea/modules/templates=43.01%
62+
code.gitea.io/gitea/modules/test=68.83%
63+
code.gitea.io/gitea/modules/timeutil=80.80%
64+
code.gitea.io/gitea/modules/translation=60.70%
65+
code.gitea.io/gitea/modules/typesniffer=92.86%
66+
code.gitea.io/gitea/modules/updatechecker=0.00%
67+
code.gitea.io/gitea/modules/upload=73.85%
68+
code.gitea.io/gitea/modules/uri=27.78%
69+
code.gitea.io/gitea/modules/user=23.53%
70+
code.gitea.io/gitea/modules/util=72.93%
71+
code.gitea.io/gitea/modules/validation=79.4%
72+
code.gitea.io/gitea/modules/watcher=0.00%
73+
code.gitea.io/gitea/modules/web=76.76%
74+
code.gitea.io/gitea/modules/webhook=13.3%
75+
code.gitea.io/gitea/models/activities=58.48%
76+
code.gitea.io/gitea/models/admin=33.55%
77+
code.gitea.io/gitea/models/asymkey=41.40%
78+
code.gitea.io/gitea/models/auth=46.36%
79+
code.gitea.io/gitea/models/avatars=31.82%
80+
code.gitea.io/gitea/models/db=41.53%
81+
code.gitea.io/gitea/models/git=44.19%
82+
code.gitea.io/gitea/models/issues=57.31%
83+
code.gitea.io/gitea/models/organization=71.00%
84+
code.gitea.io/gitea/models/packages=71.66%
85+
code.gitea.io/gitea/models/perm=57.05%
86+
code.gitea.io/gitea/models/project=31.85%
87+
code.gitea.io/gitea/models/pull=36.13%
88+
code.gitea.io/gitea/models/repo=58.62%
89+
code.gitea.io/gitea/models/secret=24.56%
90+
code.gitea.io/gitea/models/system=56.16%
91+
code.gitea.io/gitea/models/unit=48.72%
92+
code.gitea.io/gitea/models/unittest=31.91%
93+
code.gitea.io/gitea/models/user=55.82%
94+
code.gitea.io/gitea/models/webhook=66.02%
95+
code.gitea.io/gitea/routers/api=60.66%
96+
code.gitea.io/gitea/routers/common=61.15%
97+
code.gitea.io/gitea/routers/install=5.7%
98+
code.gitea.io/gitea/routers/private=34.74%
99+
code.gitea.io/gitea/routers/utils=100.00%
100+
code.gitea.io/gitea/routers/web=28.95%
101+
code.gitea.io/gitea/services/agit=56.59%
102+
code.gitea.io/gitea/services/asymkey=36.73%
103+
code.gitea.io/gitea/services/attachment=60.87%
104+
code.gitea.io/gitea/services/auth=38.99%
105+
code.gitea.io/gitea/services/automerge=44.83%
106+
code.gitea.io/gitea/services/context=47.22%
107+
code.gitea.io/gitea/services/convert=73.5%
108+
code.gitea.io/gitea/services/cron=56.2%
109+
code.gitea.io/gitea/services/externalaccount=0.00%
110+
code.gitea.io/gitea/services/forms=36.5%
111+
code.gitea.io/gitea/services/gitdiff=70.52%
112+
code.gitea.io/gitea/services/issue=40.50%
113+
code.gitea.io/gitea/services/lfs=57.06%
114+
code.gitea.io/gitea/services/mailer=54.55%
115+
code.gitea.io/gitea/services/markup=100.00%
116+
code.gitea.io/gitea/services/migrations=35.97%
117+
code.gitea.io/gitea/services/mirror=29.83%
118+
code.gitea.io/gitea/services/org=49.02%
119+
code.gitea.io/gitea/services/packages=51.94%
120+
code.gitea.io/gitea/services/pull=43.34%
121+
code.gitea.io/gitea/services/release=45.09%
122+
code.gitea.io/gitea/services/repository=41.19%
123+
code.gitea.io/gitea/services/task=43.75%
124+
code.gitea.io/gitea/services/user=46.24%
125+
code.gitea.io/gitea/services/webhook=66.63%
126+
code.gitea.io/gitea/services/wiki=56.41%

0 commit comments

Comments
 (0)