Skip to content

Commit 65588b7

Browse files
kerwin612KN4CK3R
andauthored
Extract common code to new template (#26903)
I noticed that the code of several new webhook pages is highly repetitive, so I pulled out the common parts to a new template, unified reference, unified maintenance --------- Co-authored-by: KN4CK3R <[email protected]>
1 parent 6c73c0d commit 65588b7

File tree

4 files changed

+25
-68
lines changed

4 files changed

+25
-68
lines changed

templates/org/settings/hook_new.tmpl

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,5 @@
11
{{template "org/settings/layout_head" (dict "ctxData" . "pageClass" "organization settings new webhook")}}
2-
<div class="org-setting-content">
3-
<h4 class="ui top attached header">
4-
{{if .PageIsSettingsHooksNew}}{{.locale.Tr "repo.settings.add_webhook"}}{{else}}{{.locale.Tr "repo.settings.update_webhook"}}{{end}}
5-
<div class="ui right">
6-
{{template "shared/webhook/icon" .}}
7-
</div>
8-
</h4>
9-
<div class="ui attached segment">
10-
{{template "repo/settings/webhook/gitea" .}}
11-
{{template "repo/settings/webhook/gogs" .}}
12-
{{template "repo/settings/webhook/slack" .}}
13-
{{template "repo/settings/webhook/discord" .}}
14-
{{template "repo/settings/webhook/dingtalk" .}}
15-
{{template "repo/settings/webhook/telegram" .}}
16-
{{template "repo/settings/webhook/msteams" .}}
17-
{{template "repo/settings/webhook/feishu" .}}
18-
{{template "repo/settings/webhook/matrix" .}}
19-
{{template "repo/settings/webhook/wechatwork" .}}
20-
{{template "repo/settings/webhook/packagist" .}}
21-
</div>
22-
23-
{{template "repo/settings/webhook/history" .}}
24-
</div>
25-
2+
<div class="org-setting-content">
3+
{{template "webhook/new" .}}
4+
</div>
265
{{template "org/settings/layout_footer" .}}
Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,5 @@
11
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings new webhook")}}
22
<div class="repo-setting-content">
3-
<h4 class="ui top attached header">
4-
{{if .PageIsSettingsHooksNew}}{{.locale.Tr "repo.settings.add_webhook"}}{{else}}{{.locale.Tr "repo.settings.update_webhook"}}{{end}}
5-
<div class="ui right">
6-
{{template "shared/webhook/icon" .}}
7-
</div>
8-
</h4>
9-
<div class="ui attached segment">
10-
{{template "repo/settings/webhook/gitea" .}}
11-
{{template "repo/settings/webhook/gogs" .}}
12-
{{template "repo/settings/webhook/slack" .}}
13-
{{template "repo/settings/webhook/discord" .}}
14-
{{template "repo/settings/webhook/dingtalk" .}}
15-
{{template "repo/settings/webhook/telegram" .}}
16-
{{template "repo/settings/webhook/msteams" .}}
17-
{{template "repo/settings/webhook/feishu" .}}
18-
{{template "repo/settings/webhook/matrix" .}}
19-
{{template "repo/settings/webhook/wechatwork" .}}
20-
{{template "repo/settings/webhook/packagist" .}}
21-
</div>
22-
23-
{{template "repo/settings/webhook/history" .}}
3+
{{template "webhook/new" .}}
244
</div>
255
{{template "repo/settings/layout_footer" .}}

templates/user/settings/hook_new.tmpl

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,5 @@
11
{{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings new webhook")}}
22
<div class="user-setting-content">
3-
<div class="user-setting-content">
4-
<h4 class="ui top attached header">
5-
{{if .PageIsSettingsHooksNew}}{{.locale.Tr "repo.settings.add_webhook"}}{{else}}{{.locale.Tr "repo.settings.update_webhook"}}{{end}}
6-
<div class="ui right">
7-
{{template "shared/webhook/icon" .}}
8-
</div>
9-
</h4>
10-
<div class="ui attached segment">
11-
{{template "repo/settings/webhook/gitea" .}}
12-
{{template "repo/settings/webhook/gogs" .}}
13-
{{template "repo/settings/webhook/slack" .}}
14-
{{template "repo/settings/webhook/discord" .}}
15-
{{template "repo/settings/webhook/dingtalk" .}}
16-
{{template "repo/settings/webhook/telegram" .}}
17-
{{template "repo/settings/webhook/msteams" .}}
18-
{{template "repo/settings/webhook/feishu" .}}
19-
{{template "repo/settings/webhook/matrix" .}}
20-
{{template "repo/settings/webhook/wechatwork" .}}
21-
{{template "repo/settings/webhook/packagist" .}}
22-
</div>
23-
24-
{{template "repo/settings/webhook/history" .}}
25-
</div>
3+
{{template "webhook/new" .}}
264
</div>
275
{{template "user/settings/layout_footer" .}}

templates/webhook/new.tmpl

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<h4 class="ui top attached header">
2+
{{if .PageIsSettingsHooksNew}}{{.locale.Tr "repo.settings.add_webhook"}}{{else}}{{.locale.Tr "repo.settings.update_webhook"}}{{end}}
3+
<div class="ui right">
4+
{{template "shared/webhook/icon" .}}
5+
</div>
6+
</h4>
7+
<div class="ui attached segment">
8+
{{template "repo/settings/webhook/gitea" .}}
9+
{{template "repo/settings/webhook/gogs" .}}
10+
{{template "repo/settings/webhook/slack" .}}
11+
{{template "repo/settings/webhook/discord" .}}
12+
{{template "repo/settings/webhook/dingtalk" .}}
13+
{{template "repo/settings/webhook/telegram" .}}
14+
{{template "repo/settings/webhook/msteams" .}}
15+
{{template "repo/settings/webhook/feishu" .}}
16+
{{template "repo/settings/webhook/matrix" .}}
17+
{{template "repo/settings/webhook/wechatwork" .}}
18+
{{template "repo/settings/webhook/packagist" .}}
19+
</div>
20+
{{template "repo/settings/webhook/history" .}}

0 commit comments

Comments
 (0)