Fix a compare page 404 bug when the pull request disabled (#35441) (#35453)

GiteaBot · lunny · web-flow · commit 67977f0b1c7a · 2025-09-10T22:39:50.000+08:00
Backport #35441 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
diff --git a/routers/web/repo/compare.go b/routers/web/repo/compare.go
@@ -523,7 +523,7 @@ func ParseCompareInfo(ctx *context.Context) *common.CompareInfo {
 
 	// Treat as pull request if both references are branches
 	if ctx.Data["PageIsComparePull"] == nil {
-		ctx.Data["PageIsComparePull"] = headIsBranch && baseIsBranch
+		ctx.Data["PageIsComparePull"] = headIsBranch && baseIsBranch && permBase.CanReadIssuesOrPulls(true)
 	}
 
 	if ctx.Data["PageIsComparePull"] == true && !permBase.CanReadIssuesOrPulls(true) {
@@ -735,6 +735,7 @@ func CompareDiff(ctx *context.Context) {
 		return
 	}
 
+	ctx.Data["PageIsViewCode"] = true
 	ctx.Data["PullRequestWorkInProgressPrefixes"] = setting.Repository.PullRequest.WorkInProgressPrefixes
 	ctx.Data["DirectComparison"] = ci.DirectComparison
 	ctx.Data["OtherCompareSeparator"] = ".."

Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ func ParseCompareInfo(ctx context.Context) common.CompareInfo {`
`523`	`523`
`524`	`524`	`// Treat as pull request if both references are branches`
`525`	`525`	`if ctx.Data["PageIsComparePull"] == nil {`
`526`		`- ctx.Data["PageIsComparePull"] = headIsBranch && baseIsBranch`
	`526`	`+ ctx.Data["PageIsComparePull"] = headIsBranch && baseIsBranch && permBase.CanReadIssuesOrPulls(true)`
`527`	`527`	`}`
`528`	`528`
`529`	`529`	`if ctx.Data["PageIsComparePull"] == true && !permBase.CanReadIssuesOrPulls(true) {`
`@@ -735,6 +735,7 @@ func CompareDiff(ctx *context.Context) {`
`735`	`735`	`return`
`736`	`736`	`}`
`737`	`737`
	`738`	`+ ctx.Data["PageIsViewCode"] = true`
`738`	`739`	`ctx.Data["PullRequestWorkInProgressPrefixes"] = setting.Repository.PullRequest.WorkInProgressPrefixes`
`739`	`740`	`ctx.Data["DirectComparison"] = ci.DirectComparison`
`740`	`741`	`ctx.Data["OtherCompareSeparator"] = ".."`