Fix lint

lunny · lunny · commit 7445aaecf9e8 · 2024-04-18T17:18:13.000+08:00
diff --git a/routers/web/repo/pull_review.go b/routers/web/repo/pull_review.go
@@ -273,12 +273,11 @@ func SubmitReview(ctx *context.Context) {
 
 	// as a missing / blocking reviews could have blocked a pending automerge let's recheck
 	if reviewType == issues_model.ReviewTypeApprove {
-		pr, err := issue.GetPullRequest(ctx)
-		if err != nil {
+		if err := issue.LoadPullRequest(ctx); err != nil {
 			ctx.ServerError("GetPullRequest", err)
 			return
 		}
-		automerge.MergeScheduledPullRequest(pr)
+		automerge.MergeScheduledPullRequest(issue.PullRequest)
 	}
 
 	ctx.JSONRedirect(fmt.Sprintf("%s/pulls/%d#%s", ctx.Repo.RepoLink, issue.Index, comm.HashTag()))

Original file line number	Diff line number	Diff line change
`@@ -273,12 +273,11 @@ func SubmitReview(ctx *context.Context) {`
`273`	`273`
`274`	`274`	`// as a missing / blocking reviews could have blocked a pending automerge let's recheck`
`275`	`275`	`if reviewType == issues_model.ReviewTypeApprove {`
`276`		`- pr, err := issue.GetPullRequest(ctx)`
`277`		`- if err != nil {`
	`276`	`+ if err := issue.LoadPullRequest(ctx); err != nil {`
`278`	`277`	`ctx.ServerError("GetPullRequest", err)`
`279`	`278`	`return`
`280`	`279`	`}`
`281`		`- automerge.MergeScheduledPullRequest(pr)`
	`280`	`+ automerge.MergeScheduledPullRequest(issue.PullRequest)`
`282`	`281`	`}`
`283`	`282`
`284`	`283`	`ctx.JSONRedirect(fmt.Sprintf("%s/pulls/%d#%s", ctx.Repo.RepoLink, issue.Index, comm.HashTag()))`