simplify deletion of attachments in DB

adelowo · adelowo · commit 7832a9ada0e5 · 2019-09-18T12:24:53.000+01:00
diff --git a/models/release.go b/models/release.go
@@ -381,11 +381,8 @@ func DeleteReleaseByID(id int64, doer *User, delTag bool) error {
 		uuids = append(uuids, attachment.UUID)
 	}
 
-	if _, err := x.In("uuid", uuids).Delete(new(Attachment)); err != nil {
-		return err
-	}
-
-	return nil
+	_, err := x.Delete(&Attachment{ReleaseID: id})
+	return err
 }
 
 // SyncReleasesWithTags synchronizes release table with repository tags

Original file line number	Diff line number	Diff line change
`@@ -381,11 +381,8 @@ func DeleteReleaseByID(id int64, doer *User, delTag bool) error {`
`381`	`381`	`uuids = append(uuids, attachment.UUID)`
`382`	`382`	`}`
`383`	`383`
`384`		`- if _, err := x.In("uuid", uuids).Delete(new(Attachment)); err != nil {`
`385`		`- return err`
`386`		`- }`
`387`		`-`
`388`		`- return nil`
	`384`	`+ _, err := x.Delete(&Attachment{ReleaseID: id})`
	`385`	`+ return err`
`389`	`386`	`}`
`390`	`387`
`391`	`388`	`// SyncReleasesWithTags synchronizes release table with repository tags`