Fix multiple markdown rendering bugs

Author: silverwind

web_src/js/markup/asciicast.js

@@ -1,4 +1,4 @@
-export async function renderAsciinemaPlayer() {
+export async function renderAsciicast() {
   const els = document.querySelectorAll('.asciinema-player-container');
   if (!els.length) return;
 

web_src/js/markup/common.js

@@ -0,0 +1,8 @@
+export function displayError(el, err) {
+  el.classList.remove('is-loading');
+  const errorNode = document.createElement('div');
+  errorNode.setAttribute('class', 'ui message error markup-block-error gt-mono');
+  errorNode.textContent = err.str || err.message || String(err);
+  el.before(errorNode);
+  el.setAttribute('data-done', 'true');
+}

web_src/js/markup/content.js

@@ -1,15 +1,15 @@
 import {renderMermaid} from './mermaid.js';
 import {renderMath} from './math.js';
 import {renderCodeCopy} from './codecopy.js';
-import {renderAsciinemaPlayer} from './asciicast.js';
+import {renderAsciicast} from './asciicast.js';
 import {initMarkupTasklist} from './tasklist.js';
 
 // code that runs for all markup content
 export function initMarkupContent() {
   renderMermaid();
   renderMath();
   renderCodeCopy();
-  renderAsciinemaPlayer();
+  renderAsciicast();
 }
 
 // code that only runs for comments

web_src/js/markup/math.js

@@ -1,14 +1,8 @@
-function displayError(el, err) {
-  const target = targetElement(el);
-  target.classList.remove('is-loading');
-  const errorNode = document.createElement('div');
-  errorNode.setAttribute('class', 'ui message error markup-block-error gt-mono');
-  errorNode.textContent = err.str || err.message || String(err);
-  target.before(errorNode);
-}
+import {displayError} from './common.js';
 
 function targetElement(el) {
-  // The target element is either the current element if it has the `is-loading` class or the pre that contains it
+  // The target element is either the current element if it has the
+  // `is-loading` class or the pre that contains it
   return el.classList.contains('is-loading') ? el : el.closest('pre');
 }
 
@@ -22,6 +16,8 @@ export async function renderMath() {
   ]);
 
   for (const el of els) {
+    const target = targetElement(el);
+    if (target.hasAttribute('data-done')) continue;
     const source = el.textContent;
     const displayMode = el.classList.contains('display');
     const nodeName = displayMode ? 'p' : 'span';
@@ -33,9 +29,9 @@ export async function renderMath() {
         maxExpand: 50,
         displayMode,
       });
-      targetElement(el).replaceWith(tempEl);
+      target.replaceWith(tempEl);
     } catch (error) {
-      displayError(el, error);
+      displayError(target, error);
     }
   }
 }

web_src/js/markup/mermaid.js

@@ -1,5 +1,6 @@
 import {isDarkTheme} from '../utils.js';
 import {makeCodeCopyButton} from './codecopy.js';
+import {displayError} from './common.js';
 
 const {mermaidMaxSourceCharacters} = window.config;
 
@@ -9,14 +10,6 @@ const iframeCss = `
   #mermaid {display: block; margin: 0 auto}
 `;
 
-function displayError(el, err) {
-  el.closest('pre').classList.remove('is-loading');
-  const errorNode = document.createElement('div');
-  errorNode.setAttribute('class', 'ui message error markup-block-error gt-mono');
-  errorNode.textContent = err.str || err.message || String(err);
-  el.closest('pre').before(errorNode);
-}
-
 export async function renderMermaid() {
   const els = document.querySelectorAll('.markup code.language-mermaid');
   if (!els.length) return;
@@ -30,33 +23,35 @@ export async function renderMermaid() {
   });
 
   for (const el of els) {
-    const source = el.textContent;
+    const pre = el.closest('pre');
+    if (pre.hasAttribute('data-done')) continue;
 
+    const source = el.textContent;
     if (mermaidMaxSourceCharacters >= 0 && source.length > mermaidMaxSourceCharacters) {
-      displayError(el, new Error(`Mermaid source of ${source.length} characters exceeds the maximum allowed length of ${mermaidMaxSourceCharacters}.`));
+      displayError(pre, new Error(`Mermaid source of ${source.length} characters exceeds the maximum allowed length of ${mermaidMaxSourceCharacters}.`));
       continue;
     }
 
     try {
       await mermaid.parse(source);
     } catch (err) {
-      displayError(el, err);
-      el.closest('pre').classList.remove('is-loading');
+      displayError(pre, err);
       continue;
     }
 
     try {
       // can't use bindFunctions here because we can't cross the iframe boundary. This
       // means js-based interactions won't work but they aren't intended to work either
       const {svg} = await mermaid.render('mermaid', source);
-      const heightStr = (svg.match(/viewBox="(.+?)"/) || ['', ''])[1].split(/\s+/)[3];
-      if (!heightStr) return displayError(el, new Error('Could not determine chart height'));
 
       const iframe = document.createElement('iframe');
       iframe.classList.add('markup-render');
-      iframe.sandbox = 'allow-scripts';
-      iframe.style.height = `${Math.ceil(parseFloat(heightStr))}px`;
+      iframe.sandbox = 'allow-scripts allow-same-origin';
       iframe.srcdoc = `<html><head><style>${iframeCss}</style></head><body>${svg}</body></html>`;
+      iframe.addEventListener('load', (e) => {
+        const height = e.target.contentWindow.document.body.clientHeight;
+        iframe.style.height = `${height}px`;
+      });
 
       const mermaidBlock = document.createElement('div');
       mermaidBlock.classList.add('mermaid-block');
@@ -66,9 +61,9 @@ export async function renderMermaid() {
       btn.setAttribute('data-clipboard-text', source);
 
       mermaidBlock.append(btn);
-      el.closest('pre').replaceWith(mermaidBlock);
+      pre.replaceWith(mermaidBlock);
     } catch (err) {
-      displayError(el, err);
+      displayError(pre, err);
     }
   }
 }