Skip redundant LoadAttributes in convert layer when batch-loaded

ToActionWorkflowRun and ToActionTask both call LoadAttributes
unconditionally, which re-queries repos and loads unused task steps
even when the list handler has already batch-loaded everything.

Guard both with a nil check on the already-populated field: skip
LoadAttributes when TriggerUser (runs) or Job (tasks) is set.

Author: myers

services/convert/convert.go

@@ -224,8 +224,10 @@ func ToTag(repo *repo_model.Repository, t *git.Tag) *api.Tag {
 
 // ToActionTask convert a actions_model.ActionTask to an api.ActionTask
 func ToActionTask(ctx context.Context, t *actions_model.ActionTask) (*api.ActionTask, error) {
-	if err := t.LoadAttributes(ctx); err != nil {
-		return nil, err
+	if t.Job == nil {
+		if err := t.LoadAttributes(ctx); err != nil {
+			return nil, err
+		}
 	}
 
 	url := strings.TrimSuffix(setting.AppURL, "/") + t.GetRunLink()
@@ -248,9 +250,10 @@ func ToActionTask(ctx context.Context, t *actions_model.ActionTask) (*api.Action
 }
 
 func ToActionWorkflowRun(ctx context.Context, repo *repo_model.Repository, run *actions_model.ActionRun) (*api.ActionWorkflowRun, error) {
-	err := run.LoadAttributes(ctx)
-	if err != nil {
-		return nil, err
+	if run.TriggerUser == nil {
+		if err := run.LoadAttributes(ctx); err != nil {
+			return nil, err
+		}
 	}
 	status, conclusion := ToActionsStatus(run.Status)
 	return &api.ActionWorkflowRun{