Fix CodeQL code scanning alerts

Address CodeQL alerts by handling integer conversions at callee level
using generics and bounding allocations:

- Make paginator.New and NewPagination generic [T ~int | ~int64] to
  safely accept both int and int64, clamping internally
- Change SetLinkHeader to accept int64 (methods can't be generic in Go)
- Use strconv.Atoi(fmt.Sprint(...)) in htmlrenderer to avoid int64
  intermediate
- Clamp regex match indices in escape_stream to prevent
  allocation-size-overflow
- Fix over-allocation in SanitizeCredentialURLs
- Cap slice pre-allocation in GetIssueDependencies

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Author: silverwind

modules/charset/escape_stream.go

@@ -61,12 +61,14 @@ func (e *escapeStreamer) Text(data string) error {
 			until = len(data)
 			next = until
 		} else {
-			until, next = nextIdxs[0]+pos, nextIdxs[1]+pos
+			until = min(nextIdxs[0]+pos, len(data))
+			next = min(nextIdxs[1]+pos, len(data))
 		}
 
 		// from pos until we know that the runes are not \r\t\n or even ' '
-		runes := make([]rune, 0, next-until)
-		positions := make([]int, 0, next-until+1)
+		n := next - until
+		runes := make([]rune, 0, n)
+		positions := make([]int, 0, n+1)
 
 		for pos < until {
 			r, sz := utf8.DecodeRune(dataBytes[pos:])

modules/paginator/paginator.go

@@ -4,7 +4,11 @@
 
 package paginator
 
-import "code.gitea.io/gitea/modules/util"
+import (
+	"math"
+
+	"code.gitea.io/gitea/modules/util"
+)
 
 /*
 In template:
@@ -44,15 +48,16 @@ type Paginator struct {
 }
 
 // New initialize a new pagination calculation and returns a Paginator as result.
-func New(total, pagingNum, current, numPages int) *Paginator {
+func New[T ~int | ~int64](total T, pagingNum, current, numPages int) *Paginator {
 	pagingNum = max(pagingNum, 1)
-	totalPages := util.Iif(total == -1, -1, (total+pagingNum-1)/pagingNum)
-	if total >= 0 {
+	t := int(min(int64(total), int64(math.MaxInt)))
+	totalPages := util.Iif(t == -1, -1, (t+pagingNum-1)/pagingNum)
+	if t >= 0 {
 		current = min(current, totalPages)
 	}
 	current = max(current, 1)
 	return &Paginator{
-		total:      total,
+		total:      t,
 		totalPages: totalPages,
 		current:    current,
 		pagingNum:  pagingNum,

modules/templates/htmlrenderer.go

@@ -21,7 +21,6 @@ import (
 	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/templates/scopedtmpl"
-	"code.gitea.io/gitea/modules/util"
 )
 
 type TemplateExecutor scopedtmpl.TemplateExecutor
@@ -159,15 +158,15 @@ func (p *templateErrorPrettier) makeDetailedError(errMsg, tmplName string, lineN
 	if err != nil {
 		return fmt.Sprintf("template error: %s, and unable to find template file %q", errMsg, tmplName)
 	}
-	line, err := util.ToInt64(lineNum)
+	line, err := strconv.Atoi(fmt.Sprint(lineNum))
 	if err != nil {
 		return fmt.Sprintf("template error: %s, unable to parse template %q line number %q", errMsg, tmplName, lineNum)
 	}
-	pos, err := util.ToInt64(posNum)
+	pos, err := strconv.Atoi(fmt.Sprint(posNum))
 	if err != nil {
 		return fmt.Sprintf("template error: %s, unable to parse template %q pos number %q", errMsg, tmplName, posNum)
 	}
-	detail := extractErrorLine(code, int(line), int(pos), target)
+	detail := extractErrorLine(code, line, pos, target)
 
 	var msg string
 	if pos >= 0 {

modules/util/sanitize.go

@@ -36,7 +36,7 @@ func SanitizeCredentialURLs(s string) string {
 	if schemeSepPos == -1 || bytes.IndexByte(bs[schemeSepPos:], '@') == -1 {
 		return s // fast return if there is no URL scheme or no userinfo
 	}
-	out := make([]byte, 0, len(bs)+len(userPlaceholder))
+	out := make([]byte, 0, len(bs))
 	for schemeSepPos != -1 {
 		schemeSepPos += 3         // skip the "://"
 		sepAtPos := -1            // the possible '@' position: "https://foo@[^here]host"

routers/api/v1/admin/email.go

@@ -51,7 +51,7 @@ func GetAllEmails(ctx *context.APIContext) {
 		results[i] = convert.ToEmailSearch(emails[i])
 	}
 
-	ctx.SetLinkHeader(int(maxResults), listOptions.PageSize)
+	ctx.SetLinkHeader(maxResults, listOptions.PageSize)
 	ctx.SetTotalCountHeader(maxResults)
 	ctx.JSON(http.StatusOK, &results)
 }

routers/api/v1/admin/hooks.go

@@ -77,7 +77,7 @@ func ListHooks(ctx *context.APIContext) {
 		}
 		hooks[i] = h
 	}
-	ctx.SetLinkHeader(int(total), listOptions.PageSize)
+	ctx.SetLinkHeader(total, listOptions.PageSize)
 	ctx.SetTotalCountHeader(total)
 	ctx.JSON(http.StatusOK, hooks)
 }

routers/api/v1/admin/org.go

@@ -117,7 +117,7 @@ func GetAllOrgs(ctx *context.APIContext) {
 		orgs[i] = convert.ToOrganization(ctx, organization.OrgFromUser(users[i]))
 	}
 
-	ctx.SetLinkHeader(int(maxResults), listOptions.PageSize)
+	ctx.SetLinkHeader(maxResults, listOptions.PageSize)
 	ctx.SetTotalCountHeader(maxResults)
 	ctx.JSON(http.StatusOK, &orgs)
 }

routers/api/v1/admin/user.go

@@ -534,7 +534,7 @@ func SearchUsers(ctx *context.APIContext) {
 		results[i] = convert.ToUser(ctx, users[i], ctx.Doer)
 	}
 
-	ctx.SetLinkHeader(int(maxResults), listOptions.PageSize)
+	ctx.SetLinkHeader(maxResults, listOptions.PageSize)
 	ctx.SetTotalCountHeader(maxResults)
 	ctx.JSON(http.StatusOK, &results)
 }

routers/api/v1/notify/repo.go

@@ -125,7 +125,7 @@ func ListRepoNotifications(ctx *context.APIContext) {
 		return
 	}
 
-	ctx.SetLinkHeader(int(totalCount), opts.PageSize)
+	ctx.SetLinkHeader(totalCount, opts.PageSize)
 	ctx.SetTotalCountHeader(totalCount)
 	ctx.JSON(http.StatusOK, convert.ToNotifications(ctx, nl))
 }

routers/api/v1/notify/user.go

@@ -86,7 +86,7 @@ func ListNotifications(ctx *context.APIContext) {
 		return
 	}
 
-	ctx.SetLinkHeader(int(totalCount), opts.PageSize)
+	ctx.SetLinkHeader(totalCount, opts.PageSize)
 	ctx.SetTotalCountHeader(totalCount)
 	ctx.JSON(http.StatusOK, convert.ToNotifications(ctx, nl))
 }