Skip to content

Commit d6eb6c9

Browse files
fix: update enable_prune even if mirror_interval is not provided (#28905) (#28929)
Backport #28905 by @Anthony-Jhoiro Currently, the `updateMirror` function which update the mirror interval and enable prune properties is only executed by the `Edit` function. But it is only triggered if `opts.MirrorInterval` is not null, even if `opts.EnablePrune` is not null. With this patch, it is now possible to update the enable_prune property with a patch request without modifying the mirror_interval. ## Example request with httpie ### Currently: **Does nothing** ```bash http PATCH https://gitea.your-server/api/v1/repos/myOrg/myRepo "enable_prune:=false" -A bearer -a $gitea_token ``` **Updates both properties** ```bash http PATCH https://gitea.your-server/api/v1/repos/myOrg/myRepo "enable_prune:=false" "mirror_interval=10m" -A bearer -a $gitea_token ``` ### With the patch **Updates enable_prune only** ```bash http PATCH https://gitea.your-server/api/v1/repos/myOrg/myRepo "enable_prune:=false" -A bearer -a $gitea_token ``` Co-authored-by: Anthony Quéré <[email protected]>
1 parent 55c5308 commit d6eb6c9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

routers/api/v1/repo/repo.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ func Edit(ctx *context.APIContext) {
636636
}
637637
}
638638

639-
if opts.MirrorInterval != nil {
639+
if opts.MirrorInterval != nil || opts.EnablePrune != nil {
640640
if err := updateMirror(ctx, opts); err != nil {
641641
return
642642
}

0 commit comments

Comments
 (0)