fix regression from #16075 (#18261)

noerw · web-flow · commit e4120bbc8998 · 2022-01-14T00:13:08.000+08:00
we don't want reviews to count towards comments, as this needs changes
in other components as well (eg repo stats cron job, etc).
diff --git a/models/issue_comment.go b/models/issue_comment.go
@@ -762,13 +762,12 @@ func updateCommentInfos(e *xorm.Session, opts *CreateCommentOptions, comment *Co
 			}
 		}
 		fallthrough
-	case CommentTypeReview:
-		fallthrough
 	case CommentTypeComment:
 		if _, err = e.Exec("UPDATE `issue` SET num_comments=num_comments+1 WHERE id=?", opts.Issue.ID); err != nil {
 			return err
 		}
-
+		fallthrough
+	case CommentTypeReview:
 		// Check attachments
 		attachments, err := getAttachmentsByUUIDs(e, opts.Attachments)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -762,13 +762,12 @@ func updateCommentInfos(e xorm.Session, opts CreateCommentOptions, comment *Co`
`762`	`762`	`}`
`763`	`763`	`}`
`764`	`764`	`fallthrough`
`765`		`- case CommentTypeReview:`
`766`		`- fallthrough`
`767`	`765`	`case CommentTypeComment:`
`768`	`766`	if _, err = e.Exec("UPDATE `issue` SET num_comments=num_comments+1 WHERE id=?", opts.Issue.ID); err != nil {
`769`	`767`	`return err`
`770`	`768`	`}`
`771`		`-`
	`769`	`+ fallthrough`
	`770`	`+ case CommentTypeReview:`
`772`	`771`	`// Check attachments`
`773`	`772`	`attachments, err := getAttachmentsByUUIDs(e, opts.Attachments)`
`774`	`773`	`if err != nil {`