Skip to content

Commit e8a3f95

Browse files
author
Tim Wundenberg
committed
to be squashed
1 parent cb1e538 commit e8a3f95

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

templates/repo/issue/view_content.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
</div>
140140

141141
<template id="issue-comment-editor-template">
142-
<div class="ui form comment">
142+
<form class="ui form comment">
143143
<div class="field">
144144
{{template "shared/combomarkdowneditor" (dict
145145
"CustomInit" true
@@ -162,7 +162,7 @@
162162
<button class="ui primary button">{{ctx.Locale.Tr "repo.issues.save"}}</button>
163163
</div>
164164
</div>
165-
</div>
165+
</form>
166166
</template>
167167

168168
{{template "repo/issue/view_content/reference_issue_dialog" .}}

templates/repo/issue/view_title.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,17 @@
2626
</div>
2727
</div>
2828
{{if $canEditIssueTitle}}
29-
<div class="ui form issue-title tw-hidden" id="issue-title-editor">
29+
<form class="ui form issue-title tw-hidden" id="issue-title-editor">
3030
<div class="ui input tw-flex-1">
31-
<input value="{{.Issue.Title}}" data-old-title="{{.Issue.Title}}" maxlength="255" autocomplete="off">
31+
<input name="title" value="{{.Issue.Title}}" data-old-title="{{.Issue.Title}}" maxlength="255" autocomplete="off" />
3232
</div>
3333
<div class="issue-title-buttons">
3434
<button class="ui small basic cancel button">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
3535
<button class="ui small primary button" data-update-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/title">
3636
{{ctx.Locale.Tr "repo.issues.save"}}
3737
</button>
3838
</div>
39-
</div>
39+
</form>
4040
{{end}}
4141
<div class="issue-title-meta">
4242
{{if .HasMerged}}

web_src/js/features/repo-issue-edit.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {attachRefIssueContextPopup} from './contextpopup.ts';
77
import {initCommentContent, initMarkupContent} from '../markup/content.ts';
88
import {triggerUploadStateChanged} from './comp/EditorUpload.ts';
99
import {convertHtmlToMarkdown} from '../markup/html2markdown.ts';
10+
import {applyAreYouSure} from '../vendor/jquery.are-you-sure.ts';
1011

1112
async function tryOnEditContent(e) {
1213
const clickTarget = e.target.closest('.edit-content');
@@ -86,6 +87,7 @@ async function tryOnEditContent(e) {
8687
comboMarkdownEditor = getComboMarkdownEditor(editContentZone.querySelector('.combo-markdown-editor'));
8788
if (!comboMarkdownEditor) {
8889
editContentZone.innerHTML = document.querySelector('#issue-comment-editor-template').innerHTML;
90+
applyAreYouSure(editContentZone.firstElementChild);
8991
const saveButton = querySingleVisibleElem<HTMLButtonElement>(editContentZone, '.ui.primary.button');
9092
const cancelButton = querySingleVisibleElem<HTMLButtonElement>(editContentZone, '.ui.cancel.button');
9193
comboMarkdownEditor = await initComboMarkdownEditor(editContentZone.querySelector('.combo-markdown-editor'));

web_src/js/features/repo-issue.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {GET, POST} from '../modules/fetch.ts';
1616
import {showErrorToast} from '../modules/toast.ts';
1717
import {initRepoIssueSidebar} from './repo-issue-sidebar.ts';
1818
import {fomanticQuery} from '../modules/fomantic/base.ts';
19+
import {applyAreYouSure} from '../vendor/jquery.are-you-sure.ts';
1920

2021
const {appSubUrl} = window.config;
2122

@@ -535,6 +536,8 @@ export function initRepoIssueTitleEdit() {
535536
const issueTitleEditor = document.querySelector('#issue-title-editor');
536537
if (!issueTitleEditor) return;
537538

539+
applyAreYouSure(issueTitleEditor);
540+
538541
const issueTitleInput = issueTitleEditor.querySelector('input');
539542
const oldTitle = issueTitleInput.getAttribute('data-old-title');
540543
issueTitleDisplay.querySelector('#issue-title-edit-show').addEventListener('click', () => {

0 commit comments

Comments
 (0)