When redirecting clean the path to avoid redirecting to //www.othersite.com (#5669) (#5703)

zeripath · techknowlogick · commit f5b43a615c7b · 2019-01-12T14:57:50.000-05:00
Fix #5627 Signed-off-by: Andrew Thornton <art27@cantab.net>
diff --git a/modules/public/public.go b/modules/public/public.go
@@ -117,7 +117,7 @@ func (opts *Options) handle(ctx *macaron.Context, log *log.Logger, opt *Options)
 	if fi.IsDir() {
 		// Redirect if missing trailing slash.
 		if !strings.HasSuffix(ctx.Req.URL.Path, "/") {
-			http.Redirect(ctx.Resp, ctx.Req.Request, ctx.Req.URL.Path+"/", http.StatusFound)
+			http.Redirect(ctx.Resp, ctx.Req.Request, path.Clean(ctx.Req.URL.Path+"/"), http.StatusFound)
 			return true
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ func (opts Options) handle(ctx macaron.Context, log log.Logger, opt Options)`
`117`	`117`	`if fi.IsDir() {`
`118`	`118`	`// Redirect if missing trailing slash.`
`119`	`119`	`if !strings.HasSuffix(ctx.Req.URL.Path, "/") {`
`120`		`- http.Redirect(ctx.Resp, ctx.Req.Request, ctx.Req.URL.Path+"/", http.StatusFound)`
	`120`	`+ http.Redirect(ctx.Resp, ctx.Req.Request, path.Clean(ctx.Req.URL.Path+"/"), http.StatusFound)`
`121`	`121`	`return true`
`122`	`122`	`}`
`123`	`123`