Indicate when only optional checks failed

Author: Enzime

options/locale/locale_en-US.json

@@ -1848,7 +1848,9 @@
   "repo.pulls.status_checks_success": "All checks were successful",
   "repo.pulls.status_checks_warning": "Some checks reported warnings",
   "repo.pulls.status_checks_failure": "Some checks failed",
+  "repo.pulls.status_checks_failure_optional": "Some optional checks failed",
   "repo.pulls.status_checks_error": "Some checks reported errors",
+  "repo.pulls.status_checks_error_optional": "Some optional checks reported errors",
   "repo.pulls.status_checks_requested": "Required",
   "repo.pulls.status_checks_details": "Details",
   "repo.pulls.status_checks_hide_all": "Hide all checks",

templates/repo/issue/view_content/pull_merge_box.tmpl

@@ -33,6 +33,7 @@
 			"CommitStatuses" .LatestCommitStatuses
 			"ShowHideChecks" true
 			"StatusCheckData" .StatusCheckData
+			"RequiredStatusCheckState" .RequiredStatusCheckState
 		)}}
 		</div>
 		{{end}}

templates/repo/pulls/status.tmpl

@@ -3,6 +3,7 @@
 * CommitStatuses: all commit status elements
 * ShowHideChecks: whether use a button to show/hide the checks
 * StatusCheckData: additional status check data, see backend pullCommitStatusCheckData struct
+* RequiredStatusCheckState: status state for required checks only (used to show "optional checks failed" message)
 */}}
 {{$statusCheckData := .StatusCheckData}}
 {{if .CommitStatus}}
@@ -15,9 +16,17 @@
 		{{else if eq .CommitStatus.State "warning"}}
 			{{ctx.Locale.Tr "repo.pulls.status_checks_warning"}}
 		{{else if eq .CommitStatus.State "failure"}}
-			{{ctx.Locale.Tr "repo.pulls.status_checks_failure"}}
+			{{if and .RequiredStatusCheckState .RequiredStatusCheckState.IsSuccess}}
+				{{ctx.Locale.Tr "repo.pulls.status_checks_failure_optional"}}
+			{{else}}
+				{{ctx.Locale.Tr "repo.pulls.status_checks_failure"}}
+			{{end}}
 		{{else if eq .CommitStatus.State "error"}}
-			{{ctx.Locale.Tr "repo.pulls.status_checks_error"}}
+			{{if and .RequiredStatusCheckState .RequiredStatusCheckState.IsSuccess}}
+				{{ctx.Locale.Tr "repo.pulls.status_checks_error_optional"}}
+			{{else}}
+				{{ctx.Locale.Tr "repo.pulls.status_checks_error"}}
+			{{end}}
 		{{else}}
 			{{ctx.Locale.Tr "repo.pulls.status_checking"}}
 		{{end}}