Skip to content

Store potential pull request numbers on issue #10037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lunny opened this issue Jan 28, 2020 · 4 comments
Open

Store potential pull request numbers on issue #10037

lunny opened this issue Jan 28, 2020 · 4 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@lunny
Copy link
Member

lunny commented Jan 28, 2020

Once a pull request claim it will fix some issues, then these issues could save them and display them on issues list and issue view page.
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jan 28, 2020
@guillep2k
Copy link
Member

It's only a display thing, as the information is already there. To get the info, we just need to get the issues' comments whose RefAction is XRefActionCloses (or XRefActionReopen, eventually). We need to be careful as there might be more than one PR claiming to close an issue, but other than that the info is there.

@InExtremaRes
Copy link

Is this proposal somewhat similar to this GitHub feature (with maybe different UI, of course)?

image

That would be great!

@lunny
Copy link
Member Author

lunny commented Feb 8, 2020

@guillep2k We could chose the first open pull request as a beginning. Show more than 1 pull links on pull request list page is more complicated on UI.

@lunny
Copy link
Member Author

lunny commented Apr 4, 2025

This should be resolved by #31899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @InExtremaRes @guillep2k