Skip to content

5000 commenting on a line with accented chars #10393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 7 tasks
rlogiacco opened this issue Feb 21, 2020 · 2 comments
Closed
2 of 7 tasks

5000 commenting on a line with accented chars #10393

rlogiacco opened this issue Feb 21, 2020 · 2 comments
Labels
issue/duplicate The issue has already been reported.

Comments

@rlogiacco
Copy link

  • Gitea version (or commit ref): 1.11.1
  • Git version:
  • Operating system: linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Commenting on a pull request on a line containing accented characters produces a 500 error with the following log:

2020/02/21 10:48:46 .../repo/pull_review.go:48:CreateCodeComment() [E] CreateCodeComment: Error 1366: Incorrect string value: '\xE8 vali...' for column 'patch' at row 1

The line this comment was pointing at is

			throw new Exception("ATTENZIONE: La Sessione HTTP non è valida");
@lunny
Copy link
Member

lunny commented Feb 21, 2020

Maybe you should use utf8mb4 charset on your app.ini

@lunny lunny added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Feb 21, 2020
@guillep2k guillep2k added issue/duplicate The issue has already been reported. and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Feb 21, 2020
@guillep2k
Copy link
Member

This happens when the file itself is not using utf-8 (e.g. ISO-8859-1).
This is a duplicate of #7270.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Development

No branches or pull requests

3 participants