Skip to content

feature-request: Improve PR review comments #10656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Unarelith opened this issue Mar 7, 2020 · 6 comments
Closed

feature-request: Improve PR review comments #10656

Unarelith opened this issue Mar 7, 2020 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@Unarelith
Copy link

Unarelith commented Mar 7, 2020

  • Gitea version (or commit ref): 1.11.0

Description

Gitea is great, when when it comes to reviewing pull requests, there's some flaws I'd like to discuss.

  • It's impossible to edit or delete a review comment from the "Conversation" tab
  • There's no "Resolve conversation" button (like on GitHub), making reviewing a pain for both maintainers and contributors because it's hard to keep track of already resolved comments
  • The full page is reloading when adding a review comment, and then moving to back to the comment. Most of the time this is ok, but on very small machines running Gitea, it takes a lot of time... Nevermind there's already Review page should not get refresh on adding comment #8861 for this.
@stale
Copy link

stale bot commented May 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label May 6, 2020
@Unarelith
Copy link
Author

Keep it alive

@stale stale bot removed the issue/stale label May 7, 2020
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels May 8, 2020
@aloosley
Copy link

aloosley commented Jun 4, 2020

I would also really like to see a resolve conversation option.

We are working on our first decent sized PR on Gitea. Mostly it's gone well, but the commenting is a mess! A resolve conversation option would go along way.

@bendem
Copy link

bendem commented Jul 7, 2020

I'm confused, are you asking for this (this is a screenshot from gitea itself)?
image

@lunny
Copy link
Member

lunny commented Jul 7, 2020

@aloosley It's already implemented but maybe you are using an old version gitea.

@aloosley
Copy link

aloosley commented Jul 7, 2020

@aloosley It's already implemented but maybe you are using an old version gitea.

Thanks @lunny , I didn't see it had been added. I can confirm the feature is there when I use 1.12.1. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

5 participants