bug: Attachments are not displayed on issues

[bkraul]

• Gitea version (or commit ref): 1.12.0+dev-247-g1bdffefc0
• Can you reproduce the bug at https://try.gitea.io:
  • Yes: https://dev-git.epginsurance.com/bkraul/test/issues/1
  • No
  • Not relevant
• Log gist:

Description

Attachments added to an issue as part of comments are not being displayed. If an attachment is added by itself, the comment on the issue reads "Attached file".

Screenshots

[lunny]

Will be resolved by #11272

[6543]

should be closed now - @bkraul can you test if it works now on latest master build?

[bkraul]

Sure thing man, as soon as CI builds the docker image:

Thanks for the quick action! 👍

[bkraul]

Ok, so try.gitea.com has been updated, and the attachments "work" to an extent. Picture attachments seem to be working OK, but uploading other formats does not work. For example, I am trying to upload a docx file. It does not show up or there is any trace of it being uploaded. I know it is supported:

[lunny]

Why did you think try.gitea.io support pdf and docx? I think it only supports images and zip files.

[bkraul]

I sent you a screenshot of what try.gitea.io says it supports (granted it is kind of weird that docx is put together with zip Archive..). And I know it does support PDFs and docx as well. Don't quite remember if there is a setting for MIME types that has to be configured for handling. But those were working on previous versions (pdf and docx).

[bkraul]

And yes, I can see there is a setting on app.ini for this on app.ini. My local one is set to:

[attachment]
PATH          = /data/gitea/attachments
ALLOWED_TYPES = */*

But I have not tried it there because the build was not ready, will try now.

[bkraul]

OK, I can verify the attachment of different file types once again works on my environment (because of my allowed types setting). I think you can close this issue. However, on try.gitea.io you might want to look at that upload component, I am not sure it is in sync with what's actually allowed (because it says it allows docx). 😄

Thanks again!