Skip to content

Notification on new commit for PRs #12173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 7 tasks
bendem opened this issue Jul 7, 2020 · 1 comment
Closed
2 of 7 tasks

Notification on new commit for PRs #12173

bendem opened this issue Jul 7, 2020 · 1 comment

Comments

@bendem
Copy link

bendem commented Jul 7, 2020

  • Gitea version (or commit ref): 1.12.1
  • Git version: N/A
  • Operating system: N/A
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist: N/A

Description

There is currently no notification nor visual indicator that tells a reviewer when a PR author has pushed new changes to a branch. This causes PRs to sit, reviewers unaware that they are blocking changes.

Screenshots

Changes happened 6 days ago, got a review, author pushed changes 4 and 3 days ago, had to ask for a review because no notification or visual indicator told me to review again:

image
image

Compare this with github where it's clear there were new commits added:
image

@bendem
Copy link
Author

bendem commented Jul 7, 2020

Actually, this is a duplicate of #8365 that I didn't find at first. Closing this to keep the discussion centralised.

@bendem bendem closed this as completed Jul 7, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant