Local time zone in timestamps

[mozoh]

• Gitea version (or commit ref): 1.14.0+dev-260-g7bc0c8cff
• Git version: ?
• Operating system: docker
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL) https://try.gitea.io/explore/repos
  • No
• Log gist: n/a

Description

Popup timestamps are always in UTC, but not browser timezone wherever I am.
There is a closed issue about this #6004, but seems like it is being reproduced again.

Screenshots

[zeripath]

Paging @silverwind - is it possible recent changes to js have broken this?

[silverwind]

No, I've never touched those. I remember suggesting them to be converted in JS to browser timezone but I think @lunny persisted that they should render in the server timezone.

[Colin5887]

I've tested 1.9.0, 1.10.0, 1.11.0 and 1.12.0. They all have the same issue. This is also reproducible in https://try.gitea.io

Here: I create a repo 4 minutes ago and it's marked to be an operation yesterday.

BTW, I'm at AEDT.

[lunny]

See https://docs.gitea.io/en-us/config-cheat-sheet/#time-time . You can change the default time zone and even the format which will be displayed on UI.

[Colin5887]

@lunny I promise I change that and it works......partially works.

It only changes the time when the mouse hovers on the commit and the time IS correct now.
However, the table of contributions is still incorrect. A commit made at 9:30 is still marked as yesterday's work.
It is reproducible on https://try.gitea.io as well.

[Colin5887]

@lunny The problem is not the time in the text format but the table.

I mean, the table:

[lunny]

@Colin5887 Your problem is not the same as this one. I think you can create a new issue so that we can track that.

[Colin5887]

@lunny Thanks, a new issue is created here: #14215

[mozoh]

Why the issue has been closed? "Change timezone on server” is not the real solution.

[lunny]

@mozoh see my reply #13925 (comment)

[mozoh]

@lunny your reply is about changing default, but not for local timezone. Every client can have its own timezone, different from the server. So, there will no solution for this as i understand.

[silverwind]

Yes, we need some JS that runs during page load that converts timestamp to local. Should probably be inline so wrong timestamps never even render (can't put it in the main js bundle because that takes time to load).

[noerw]

this similar to / the same as #6087

[lunny]

#6087 is for heatmap, this one is the time on feeds .

[yardenshoham]

Fixed by #23988