Skip to content

util, helper and etc package names should be depreciated. #14557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6543 opened this issue Feb 3, 2021 · 4 comments
Closed

util, helper and etc package names should be depreciated. #14557

6543 opened this issue Feb 3, 2021 · 4 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/refactoring Existing code has been cleaned up. There should be no new functionality.

Comments

@6543
Copy link
Member

6543 commented Feb 3, 2021

util, helper and etc package names should be depreciated.

Originally posted by @lunny in #14524 (comment)
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 3, 2021
@6543
Copy link
Member Author

6543 commented Feb 3, 2021 •
edited
Loading

helpers:

"move modules/util/paginate.go to modules/paginate/paginate.go"

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 26, 2023 •
edited
Loading

We are still adding new code to the util package. So I guess it's so far so good?

ps: IMO instead of keeping issues open, I think it's better to write some PRs to refactor ... if it's worth and it is necessary 😁

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 26, 2023
@harryzcy
Copy link
Contributor

I feel utils is too vague for a package name, and it's unclear what's actually inside.

We should either use gitutil, webhookutil... or put those into respective modules or services

@harryzcy harryzcy mentioned this issue Aug 26, 2023
Closed
@GiteaBot
Copy link
Collaborator

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wxiaoguang @GiteaBot @6543 @harryzcy