Issue search failed with default DB implementation

[lunny]

[I] [SQL] SELECT DISTINCT `id` FROM `issue` WHERE repo_id IN (?) AND (UPPER(name) LIKE ? OR UPPER(content) LIKE ? OR id IN (SELECT issue_id FROM comment WHERE type=? AND issue_id IN (SELECT id FROM issue WHERE repo_id IN (?)) AND UPPER(content) LIKE ?)) ORDER BY `updated_unix` DESC LIMIT 50 [550 %TEST% %TEST% 0 550 %TEST%] - 733.388µs
2021/03/06 12:21:38 ...outers/repo/issue.go:163:issues() [E] issueIndexer.Search: Error 3065: Expression #1 of ORDER BY clause is not in SELECT list, references column 'gitea.issue.updated_unix' which is not in SELECT list; this is incompatible with DISTINCT
	/source/routers/repo/issue.go:163 (0x208cf0f)
	/source/routers/repo/issue.go:381 (0x208d358)
	/source/modules/web/route.go:53 (0x1f64d82)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/mux.go:436 (0x1b2d0ca)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/web/route.go:91 (0x1f65316)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/web/route.go:91 (0x1f65316)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/web/route.go:91 (0x1f65316)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x21946a1)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/context/context.go:672 (0x1b49061)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/base.go:91 (0x219b95a)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/base.go:91 (0x219b95a)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/public/public.go:85 (0x13eee87)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/public/public.go:85 (0x13eee87)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/base.go:190 (0x219d470)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/gitea.com/go-chi/session/session.go:256 (0x153daae)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/mux.go:70 (0x1b2ac2a)
	/source/vendor/github.com/go-chi/chi/mux.go:311 (0x1b3101b)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/mux.go:436 (0x1b2d0ca)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/web.go:93 (0x219e8bd)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/base.go:37 (0x219a61b)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x2195087)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/middleware/realip.go:34 (0x2194f3c)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/web.go:65 (0x219e3fc)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/mux.go:87 (0x1b2a9b0)
	/source/modules/web/route.go:267 (0x1f642d3)
	/source/vendor/github.com/gorilla/context/context.go:141 (0x11b00b3)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/usr/local/go/src/net/http/server.go:2887 (0x7c0662)
	/usr/local/go/src/net/http/server.go:1952 (0x7bbb8c)
	/usr/local/go/src/runtime/asm_amd64.s:1371 (0x47a460)

[lunny]

It's a mysql related problem. Mysql 5.7 change sql_mode default value to ONLY_FULL_GROUP_BY.
And take into the code, in fact, the distinct is unnecessary because id is a primary key on issue table.