Skip to content

References in pull request "main" review comments do not work. #15977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MGChecker opened this issue May 25, 2021 · 4 comments
Open

References in pull request "main" review comments do not work. #15977

MGChecker opened this issue May 25, 2021 · 4 comments
Labels
type/bug

Comments

@MGChecker
Copy link

  • Gitea version (or commit ref): 1.14.2

Description

If you reference another issue or PR in a main review comment (Approve/Request changes), the reference is not shown in the referenced issue.

This has probably the same root cause as #14567 and #13394.
@noerw noerw added the type/bug label May 25, 2021
@zokkis
Copy link
Contributor

zokkis commented Feb 10, 2024 •
edited
Loading

to reproduce

  1. create PR 1 and 2
  2. review one of the PRs and reference the other PR in 'Review comment'

The review comment:
image

no reference set:
image

@MGChecker
Copy link
Author

Yes, I agree.

@zokkis
Copy link
Contributor

zokkis commented Feb 10, 2024

Why did you close it? It's still a bug, I only wrote a comment to show how to reproduce it

@MGChecker
Copy link
Author

Sorry, I misremembered what this issue was about.

@MGChecker MGChecker reopened this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noerw @MGChecker @zokkis