Confirmation prompts: usability, accessibility, and clarity

[FWDekker]

Feature Description

Some actions in Gitea require the user to confirm the action in a prompt, for example when removing an email address or deleting an account. Currently, these confirmation prompts are formatted as "Are you sure you want to delete this account?" or "Are you sure you want to delete this repository?".

While certainly better than a vague "Are you sure about this?", this still leaves room for error. Imagine a user removing one of multiple email addresses, but the user is unaware that they clicked the delete button next to the wrong email address. The user sees "Are you sure you want to remove this email address?", wrongly interpreting what "this" refers to, confirm the action, and accidentally remove the wrong email address.

I think the prompt text should be even clearer about what the user is about to do: "Are you sure you want to delete the account Frankie?" and "Are you sure you want to delete the repository Frankie/MyFirstRepo?". GitHub goes one step further when it comes to removing accounts/repos, and asks the user to write the name of the target in an input box. This would be great, but is, in my opinion, not required. (On the other hand, GitHub also does not mention the exact email address when removing an email address.)

---

Now that I look at Gitea's confirmation dialog, I think there's a few other important improvements to be made:

• The user should be able to close the dialog very easily, in case they panic. Pressing Esc should close the dialog. Clicking in the grey area around the dialog should also close the dialog. Basically, doing anything other than clicking "Yes" should close the dialog.
• The "No" button has a trash can icon. While probably intended to signify "Throw away this action", it can be misunderstood to mean "Throw away the email address". This is confusing. Perhaps the symbols should be removed from the buttons.
• The buttons should be given colours: "Yes" should be red (i.e. danger), and "No" should remain transparent (i.e. neutral).
• The text should be given a non-transparent background to make it easier to read; currently I experience minor accessibility issues while trying to read the text.

[delvh]

The "No" button has a trash icon.

Already fixed in #17537.

[Ryuno-Ki]

Partly addressed in #19894

[FWDekker]

Not sure since when exactly, but at least as of v1.20.4 all of my points have been addressed 😄