Skip to content

APNG avatar loses animation information on upload #18907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverwind opened this issue Feb 26, 2022 · 5 comments
Closed

APNG avatar loses animation information on upload #18907

silverwind opened this issue Feb 26, 2022 · 5 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@silverwind
Copy link
Member

silverwind commented Feb 26, 2022

Gitea Version

fd273b0

Can you reproduce the bug on the Gitea demo site?

Yes

Description

APNG files lose animation information on upload. For example when uploading this APNG as an avatar, postprocessing squares it and the resulting file no longer animates.

@Gusted
Copy link
Contributor

Gusted commented Feb 26, 2022

image/png doesn't support APNG, we would need to detect this kind of PNG and use a appropriate encoder like: https://github.com/kettek/apng

@silverwind silverwind added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/bug labels Feb 26, 2022
@silverwind
Copy link
Member Author

Possibly way of detection: https://stackoverflow.com/a/4525194

@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 30, 2022
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 8, 2022
@stale stale bot removed the issue/stale label May 8, 2022
@silverwind
Copy link
Member Author

silverwind commented Apr 21, 2023

Related: #24248 (comment)

WEBP is currently converted to PNG which is not ideal. Avatar convertion module should output WEBP for WEBP input, maybe even convert all avatars to WEBP instead of PNG.

@silverwind
Copy link
Member Author

Let's continue in #24263.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

3 participants