Skip to content

Keep language statistics shown when viewport width is small #21389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ell1e opened this issue Oct 9, 2022 · 6 comments
Closed

Keep language statistics shown when viewport width is small #21389

ell1e opened this issue Oct 9, 2022 · 6 comments
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@ell1e
Copy link

ell1e commented Oct 9, 2022

Description

With a too small page width, the language statistics appear to be unreachable: the bar with the colorful language break-up below the "Commits"/"Branches"/"Tags"/"Storage" bar just disappears. With that, both the coarse statistics represented by it, as well as the click area to reach the detailed breakdown, seem to be just gone. I haven't found any other way to reach them, so that seems bad.

Maybe a fix would be to just not have it disappear?

Gitea Version

1.18.0+dev-421-geaa561145

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Screencast.from.10-09-2022.07.40.02.PM.webm

Git Version

No response

Operating System

No response

How are you running Gitea?

It reproduces on someone else's instance as well as the official demo site, I don't run it myself

Database

No response

@ell1e ell1e added the type/bug label Oct 9, 2022
@wxiaoguang
Copy link
Contributor

It's hidden when width is small. That's done by purpose, unless there is a new UI design.

@wxiaoguang wxiaoguang added type/enhancement An improvement of existing functionality and removed type/bug labels Oct 10, 2022
@wxiaoguang wxiaoguang changed the title With a too small page width, the language statistics becomeunreachable Keep language statistics shown when viewport width is small Oct 10, 2022
@ell1e
Copy link
Author

ell1e commented Oct 10, 2022

Hm, but if there is no other way to reach the same content, maybe it just shouldn't be hidden? It doesn't seem like hiding it gains much screen space anyway.

Or could there be another button or tab added to reach the language statistics on a dedicated page maybe?

@wxiaoguang
Copy link
Contributor

I could agree if there would be a better solution which enough people like. Not only the language bar, but also many other elements are hidden when width is small. That's a UI decision in history, and that's what I mean unless there is a new UI design.

@ell1e
Copy link
Author

ell1e commented Oct 10, 2022

Surely if an element disappears it should still have some other way or spot to still trigger it? (Like a hamburger menu?) And otherwise simply be left in place?

Edit: Okay, so after playing around some more, it seems like 99% or even 100% of all other stuff disappearing has some other way to get to it. E.g. while all the info on the latest commit disappears, the "X Commits" button still gets you to the list of commits. Or for the per file commit message, you click the file, then "History", and there, still reachable. The language stats seem about one of the only things that just go away with no replacement.

Why not just leave everything as it is but make the language bar not disappear?

@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Oct 12, 2022
@ell1e
Copy link
Author

ell1e commented Oct 16, 2022

Okay, so I think this CSS section should simply be removed:

@media (max-width: 767px) {
 .repository .repository-summary .segment.language-stats {
  display:none;
 }
}

How it looks like with that section gone:
Screenshot from 2022-10-16 08-56-39

Currently/without that removed:
Screenshot from 2022-10-16 08-55-55

@wxiaoguang
Copy link
Contributor

It should have been fixed by " Improve "language stats" UI #26968 " (although the UI is not perfect)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants