Skip to content

[actions] Multiline copy should not include line numbers #25365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Thalhammer opened this issue Jun 19, 2023 · 1 comment
Closed

[actions] Multiline copy should not include line numbers #25365

Thalhammer opened this issue Jun 19, 2023 · 1 comment
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@Thalhammer
Copy link

Description

When trying to copy multiple lines of output from a actions step it will include line numbers.
This is especially annoying if actions produce user readable output that needs to be preserved and executed as given (e.g. a lint job outputing a git patch command), because you need to first copy it to a text editor, remove the line numbers and then apply it. This adds an extra, really annoying step.

Instead it should only copy the content, not including the line numbers, like it does in diff/code view.

For my own actions I can work around this by putting everything on a single line and relying on gitea's line wrapping, but this should probably be changed none the less.

The easy way to achieve this (and the way I did it for the below screenshot) would be to add the following css, however this prevents selection of the numbers entirely, which might not be what everyone wants. It might be better to have a gui config and let people select.

.job-log-line .line-num {
    -webkit-user-select: none;
    -ms-user-select: none;
    user-select: none;
}

Screenshots

What it looks like

What its supposed to look like

Gitea Version

1.19.3

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Linux (Google Chrome)

Browser Version

Version 114.0.5735.106

@Thalhammer Thalhammer added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 19, 2023
@wolfogre
Copy link
Member

Fixed by #24594. You could use v1.20.0-rc0 or wait for v1.20.0/v1.19.4

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

2 participants