Skip to content

The Open button in the PR list lacks some checks #27553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lng2020 opened this issue Oct 10, 2023 · 3 comments
Closed

The Open button in the PR list lacks some checks #27553

lng2020 opened this issue Oct 10, 2023 · 3 comments
Labels

Comments

@lng2020
Copy link
Member

lng2020 commented Oct 10, 2023

Description

ksnip_20231010-113026
Currently, the only check of this button is

if issue.IsPull && issue.PullRequest.HasMerged {
continue
}

This will cause some problems such as when the head branch is deleted or the fork repo changes the visibility.

ksnip_20231008-161624

But I'm not really sure about the whole check condition. Are there any other cases that the PR should not be reopened?

Gitea Version

latest codebase

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

built from source code

Database

None

@yp05327
Copy link
Contributor

yp05327 commented Mar 27, 2024

same to #26106?

@lunny
Copy link
Member

lunny commented Mar 27, 2024

This issue is for the pull request list page but yours is for pull request detail page.

@yp05327
Copy link
Contributor

yp05327 commented Sep 26, 2024

I think this has been fixed by #32081

@yp05327 yp05327 closed this as completed Sep 26, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants