Displayed order of topics is inconsistent between repo list and repo page

[wackbyte]

Description

Problem

The order of a repository's topics is different when viewed in a repo list versus when viewed on the repo's page itself. See the screenshots below for an example.

Expected behavior

I would expect the ordering to be consistent between the two pages, either by being sorted or by staying in insertion order. Personally, I would prefer them to be sorted (as they already are on the repo page).

Demo

• Repo list https://try.gitea.io/glaggleland
• Repo page: https://try.gitea.io/glaggleland/topics

Screenshots

Order while adding:

Order after adding (on repo page):

Order in the repo list on the user profile:

(These screenshots are from the reproduction of the issue on a local test instance I built, not from try.gitea.io, but the same issue occurs there.)

Gitea Version

ba24e0b

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

NixOS

Browser Version

Librewolf 121.0.1

[wackbyte]

I believe I've found the root of the issue.

The repo page (view, template) uses FindTopics to get the list of topics, which sorts them by name.

However, the repo list (view, template) uses the Topics field of the Repository struct, which I assume is not sorted.

EDIT: The code that generates the Topics field (syncTopicsInRepository) sorts by the repo count of each topic, not by name. I replaced .Desc("topic.repo_count") with .Asc("topic.name"), and the issue was fixed once I triggered a sync by editing the repo's topics.

[stuzer05]

Can we fix milestones list sorting as well? It's not alphabetical

[wackbyte]

I can look into it

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines