Skip to content

Avatar not visisble in pr commit history rows #33595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuzer05 opened this issue Feb 14, 2025 · 9 comments · Fixed by #33602
Closed

Avatar not visisble in pr commit history rows #33595

stuzer05 opened this issue Feb 14, 2025 · 9 comments · Fixed by #33602
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@stuzer05
Copy link
Contributor

Description

Avatar not set enymore in pr history

Image
but when clicking on commit hash -avatar is there
Image

Gitea Version

1.24.0+dev-306-g70327d6a92

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None
@techknowlogick
Copy link
Member

The email that is used for the commits in the PR could be different from the one used by the system when merging/squashing the PR. Could you verify that the emails are the same, and if not, then that the email for the commits is added to your profile.

@techknowlogick techknowlogick added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Feb 14, 2025
@stuzer05
Copy link
Contributor Author

Email is the same, and gitea finds it, in explore page history

Image

but in pr history it doesn't

Image

also, when chicking on commit - avatar is there, as it should be. Only pr history is broken

Image

@lunny
Copy link
Member

lunny commented Feb 14, 2025

Caused by #33528. I will send a PR to fix it.

@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Feb 14, 2025
@lunny lunny mentioned this issue Feb 15, 2025
Merged
@lunny
Copy link
Member

lunny commented Feb 15, 2025

I sent #33602 to fix this, please review.

@techknowlogick
Copy link
Member

@stuzer05 ah, my apologies. Thanks for those additional details:)

@lunny lunny closed this as completed in 01bf8da Feb 15, 2025
@stuzer05
Copy link
Contributor Author

Not fixed in 1.24.0+dev-321-gf35850f48e

@lunny
Copy link
Member

lunny commented Feb 17, 2025

Not fixed in 1.24.0+dev-321-gf35850f48e

Can you confirm the user doesn't hide his email?

@stuzer05
Copy link
Contributor Author

Email is private. But avatar is only missing in pr commit history. Elsewhere in commit history (repo, explore page, when viewing commit) - avatar visible

@lunny
Copy link
Member

lunny commented Feb 19, 2025

Email is private. But avatar is only missing in pr commit history. Elsewhere in commit history (repo, explore page, when viewing commit) - avatar visible

I will take a look at it.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug when get commit lunny/gitea
3 participants
@lunny @techknowlogick @stuzer05