500/RuntimeError while browsing organization repo list

[philippbeckmann]

• Gitea version (or commit ref): 1.8.1
• Git version: 2.21.0.windows.1
• Operating system: Windows Server 2019
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist: https://gist.github.com/philippbeckmann/5b9da6b2f45e5c940095a3dd4fa4d0de

Description

When browsing an organization and switching to another page, an error 500 is displayed. The log reports "runtime error: invalid memory address or nil pointer dereference" (see gist).

Screenshots

[trgwii]

I'm having the same issue! Have had it for a while, but until Gitea 1.8.1, the IIS reverse proxy overtook the error page, which led me to believe IIS was doing something funky with that specific response from Gitea (Page 2 or more on any organization page). With 1.8.1 the Gitea 500 page is shown instead.

Another interesting quirk is that you have to be signed in for the error to occur.

My setup:

Gitea: 1.7.6, 1.8.1
Git version: git version 2.18.0.windows.1
Operating system: Windows Server 2012 Standard
Database: MSSQL

[philippbeckmann]

I just found out that the problem does not occur to admin users. Only non-admin users are affected??!?

[trgwii]

Confirmed, same result here.

Logged out / anonymous: Works
Normal user: 500 error
Admin / root user: Works

funky bug

[philippbeckmann]

This corresponds to the code in

gitea/routers/user/home.go

Line 438 in 895764e

if ctx.IsSigned && !ctx.User.IsAdmin {

The stacktrace in my gist points to line 448

[lafriks]

Problem is actually somewhere here:
https://github.com/go-gitea/gitea/blob/v1.8.1/models/org.go#L728

or

https://github.com/go-gitea/gitea/blob/v1.8.1/routers/user/home.go#L448

[lafriks]

Could you check if branch https://github.com/lafriks/gitea/tree/backport/fix_repository_search fixes problem? I was not able to reproduce this problem locally

[lafriks]

It could be that on master this problem is already fixed by #6897

[zeripath]

I can backport that if liked

[lafriks]

I have branch with backported changes already, I was just not able to reproduce issue, so I'm not sure if it actually fixes the problem :)

[philippbeckmann]

Thank you, i'm just setting up a test environment to test a master build.

[philippbeckmann]

The issue is fixed in the current master. Thank you.

[lafriks]

Please test with latest 1.8 build when drone has finished building

[philippbeckmann]

This issue is fixed in the current 1.8 build.